New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729051 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cr50: Backport trunks_send to reef & gru factory branches.

Project Member Reported by hungte@chromium.org, Jun 2 2017

Issue description

As we've seen that Cr50 keeps pushing updates and there's request to "make sure Cr50 is updated to same version in FSI", it seems easier to mount release image rootfs and run trunks_send to update inside pytest.

The pytest is ready, but trunks_send only lives on ToT.

Per discussed in other thread, apronin thinks it may be not too hard to backport trunks_send to reef & gru factory branches.

Please try to do that and get apronin's help if you bump into any problems.
 
Copying the relevant info to the bug:

In terms of backporting the current trunks_send, yes, should be (almost) as easy as taking the latest code for it. It's meant to be a relatively simple tool using just the raw SendMessage feature of trunks, so it's almost independent from the rest of the trunks code.

To backport you need to pick all missing commits for trunks_send.cc (which is all 7 for factory-reef-8811.B; and the last 4 for factory-gru-9017). Since factory-reef doesn't have trunks_send at all yet, there, besides all trunks_send.cc commits, you also need CL:405728 to make some constants available to trunks_send and CL:402069 to add the tool to the image in ebuild. After that, it should build and work (didn't test).
BTW, this is NOT a hard requirement.

Gru & Reef factory branches already support updating via usb_updater (as upstart). However, using that implies whenever ANY projects are going to change FSI, they have to push new Cr50 binary to factory branches, get a new build of test image and push to factory. This is how we update Cr50 today for Gru&Reef.

Starting from Poppy, they'll update with trunks_send, which is more convenient since it always grabs FSI, no need to change test images.

So, I'll leave the decision to SIE. If you're ok with pushing Cr50 binaries to factory branches periodically then we don't need trunksd_send.
also, trunks_send works just fine with 0.0.13
Status: Assigned (was: Untriaged)
Will find time slot to investigate it.
Status: Started (was: Assigned)
CLs for back porting to Gru is submitted - https://chromium-review.googlesource.com/#/c/564918/
Back porting to Gru is done with a issue fix.
Status: Verified (was: Started)
Back port to Reef is done as well.

Sign in to add a comment