SimpleChrome test failing due to broken standalone clang++ wrapper |
||||
Issue descriptionguessing it's due to the recent wrapper changes https://uberchromegw.corp.google.com/i/chromiumos/builders/amd64-generic-full/builds/18735 FAILED: obj/base/allocator/tcmalloc/stacktrace.o x86_64-cros-linux-gnu-clang++ -B/tmp/cbuildbot-tmpThSOzn/chrome-sdk-cache56kRqx/cache/chrome-sdk/tarballs/amd64-generic+__b__cbuild__buildbot_archive__amd64-generic-full__R61-9609.0.0-b18735+target_toolchain/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -Wno-unknown-warning-option -MMD -MF obj/base/allocator/tcmalloc/stacktrace.o.d -DNO_HEAP_CHECK -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"303910-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DTCMALLOC_DONT_REPLACE_SYSTEM_ALLOC -I../../base/allocator -I../../third_party/tcmalloc/chromium/src/base -I../../third_party/tcmalloc/chromium/src -I../.. -Igen -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -m64 -march=x86-64 -pthread -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../../../../../../../../tmp/cbuildbot-tmpThSOzn/chrome-sdk-cache56kRqx/cache/chrome-sdk/tarballs/amd64-generic+__b__cbuild__buildbot_archive__amd64-generic-full__R61-9609.0.0-b18735+sysroot_chromeos-base_chromeos-chrome.tar.xz -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-shift-negative-value -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-reorder -Wno-unused-function -Wno-unused-local-typedefs -Wno-unused-private-field -Wno-sign-compare -Wno-unused-result -O2 -fno-ident -fdata-sections -ffunction-sections -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -Wno-inline-asm -c ../../third_party/tcmalloc/chromium/src/stacktrace.cc -o obj/base/allocator/tcmalloc/stacktrace.o File "/tmp/cbuildbot-tmpThSOzn/chrome-sdk-cache56kRqx/cache/chrome-sdk/tarballs/amd64-generic+__b__cbuild__buildbot_archive__amd64-generic-full__R61-9609.0.0-b18735+target_toolchain/bin/../usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/gcc-bin/4.9.x/x86_64-cros-linux-gnu-clang++", line 352 if '-noccache' in myargs: ^ IndentationError: unexpected indent
,
Jun 2 2017
The CL that I *think* fixes the problem is https://chromium-review.googlesource.com/c/522747/. I'm still testing it.
,
Jun 2 2017
The fix has been committed (it was chumped).
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ce9e9232d0662ee7dda70df241bde772cdfb4c8e commit ce9e9232d0662ee7dda70df241bde772cdfb4c8e Author: Caroline Tice <cmtice@google.com> Date: Fri Jun 02 18:35:17 2017 Fix indentation problem for toolchain wrapper scripts. The indentation of the code in the toolchain wrapper scripts was changed in CL:489563, but the code int cros_setup_toolchains was not changed to respect the new indentation. This causes issues with the Chrome Simple Workflow. This CL fixes that problem. BUG= chromium:729016 TEST=In Progress Change-Id: I7ff956db47dd6b86e834f13c5c720d655f29b266 Reviewed-on: https://chromium-review.googlesource.com/522747 Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Trybot-Ready: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/ce9e9232d0662ee7dda70df241bde772cdfb4c8e/scripts/cros_setup_toolchains.py
,
Jun 2 2017
.the CL that has been chumped will fix the problem, but users (and others) won't see the fix until it has gone through the chromiumos-sdk. The bug they are seeing is in a bad toolchain that they are downloading from gs://chromiumos-sdk/2017/05/*-2017.05.31.232412.tar.xz . I stopped the chromiumos-sdk build (which started around 5am this morning) , so the new builder has restarted with my patch, but it won't push a good toolchain package for about 16 hours. In the meantime, the ideal solution would be to delete the 'bad' sdk toolchains that got pushed to gs, but I don't have the privileges to do that and I'm not sure if that would have other bad repercussions. The bad packages are: gs://chromiumos-sdk/2017/05/aarch64-cros-linux-gnu-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/arm-none-eabi-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/armv6j-cros-linux-gnueabi-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/armv7a-cros-linux-gnueabi-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/i686-pc-linux-gnu-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/mipsel-cros-linux-gnu-2017.05.31.232412.tar.xz gs://chromiumos-sdk/2017/05/x86_64-cros-linux-gnu-2017.05.31.232412.tar.xz
,
Jun 2 2017
you should never mess with artifacts in GS once they're uploaded. please never try to do that without first consulting with the build team. that's not how versions are discovered anyways ... they're picked up via chromiumos-overlay/chromeos/binhost/host/sdk_version.conf which you can modify/revert.
,
Jun 2 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c260a711f37cef043b37bbc2f3dffcb6135b103a commit c260a711f37cef043b37bbc2f3dffcb6135b103a Author: Caroline Tice <cmtice@google.com> Date: Fri Jun 02 20:36:16 2017 Use old sdk_version to revert bad wrapper change. This reverts the sdk_version to the last good version (until the latest chromiumos-sdk, with bug fix, completes). Bug= chromium:729016 TEST=Downloaded this version of sdk & verified it did not contain the problem. Change-Id: Ica0443934c6f7e298f9f2a143a7d63ec8d4a9531 Reviewed-on: https://chromium-review.googlesource.com/522944 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Trybot-Ready: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/c260a711f37cef043b37bbc2f3dffcb6135b103a/chromeos/binhost/host/sdk_version.conf
,
Jun 3 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by cmt...@chromium.org
, Jun 2 2017