Refactor to make ReadingListModel* to remove the naked pointer |
|||
Issue descriptionCame up in review of ARC conversion CL https://codereview.chromium.org/2888163004/. Raw pointers in C++ aren't desirable so we should refactor that at some point.
,
Jul 13 2017
,
Jul 18 2017
What should it be replaced with? Is this part of a bigger cleanup? I see lots of raw pointers in the code.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8acc525454f1ad2fbd9347434462e26c3c0be63c commit 8acc525454f1ad2fbd9347434462e26c3c0be63c Author: Olivier Robin <olivierrobin@chromium.org> Date: Wed Aug 23 14:14:53 2017 Remove Todo 729015 This is a C++ object in an observer. It can stay naked. Bug: 729015 Change-Id: I89dc609e618c6a719610def75c322354e455aaf9 Reviewed-on: https://chromium-review.googlesource.com/628539 Reviewed-by: Eric Noyau <noyau@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496679} [modify] https://crrev.com/8acc525454f1ad2fbd9347434462e26c3c0be63c/components/reading_list/ios/reading_list_model_bridge_observer.h
,
Aug 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by linds...@chromium.org
, Jun 2 2017