update_use_counter_feature_enum.py removes unrelated OBSOLETE prefixes |
||
Issue descriptionIn https://chromium-review.googlesource.com/c/522584/ running update_use_counter_feature_enum.py has removed some `OBSOLETE_` prefixes that are unrelated to the counter that was added to the patch. Could someone from the metrics team have a look and advice if there's a bug in the tool or working as intended?
,
Jun 2 2017
This doesn't sound toe me like a bug with update_use_counter_feature_enum.py -- it's accurate that those enum entries do not have an OBSOLETE_ prefix anymore. I think the bug is that there is no presubmit script that required whoever removed those prefixes to update enums.xml accordingly.
,
Jun 5 2017
Ah, right - if the expectation is the code versions do have OBSOLETE prefixes then yeah it's not a bug with the script but a presubmit not existing for the code ones.
,
Jun 6 2017
I see, I've contacted the owner of the CL that made the change to let them know what happened. CL link: https://codereview.chromium.org/2905763003 It seems that what has happened is they updated the enums.xml file manually to mark the counters obsolete but that will just get overridden by the next run of the script. Feel free to close this bug from my point of view.
,
Jun 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||
►
Sign in to add a comment |
||
Comment 1 by asvitk...@chromium.org
, Jun 2 2017Status: Available (was: Untriaged)