New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728976 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Jul 2017
Cc:
█ kings...@google.com
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[Remote suggestions] Allow simple comparison of scheduling against the M58 Stable baseline.

Project Member Reported by jkrcal@chromium.org, Jun 2 2017 
There are a couple of scheduling changes in M59, M60, and potentially in M61. 

We should allow a simple way to perform an experimental comparison against the baseline of what is launched to M58 Stable. 

The simplest is probably trigger the previous schedule using a feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0742d2568d90672e82220c5234b77da9988086

commit eb0742d2568d90672e82220c5234b77da9988086
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Jun 08 09:16:36 2017

[Remote suggestions] Allow to switch to M58 fetching schedule simply

This CL allows simple experimental comparision of changes vs. M58.

Bug:  728976 
Change-Id: Ia977aebafba7e9004caa06fbb77128ab6d7da2ac
Reviewed-on: https://chromium-review.googlesource.com/522124
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477929}
[modify] https://crrev.com/eb0742d2568d90672e82220c5234b77da9988086/components/ntp_snippets/features.cc
[modify] https://crrev.com/eb0742d2568d90672e82220c5234b77da9988086/components/ntp_snippets/features.h
[modify] https://crrev.com/eb0742d2568d90672e82220c5234b77da9988086/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/eb0742d2568d90672e82220c5234b77da9988086/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

Comment 2 by fi...@chromium.org, Jul 21 2017

Labels: -Type-Bug M-62 zine-triaged Type-Feature
Is this done?

Comment 3 by jkrcal@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
Yes.
►

Sign in to add a comment