New issue
Advanced search Search tips

Issue 728965 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 717984



Sign in to add a comment

Enable TabsInCBD flag for Android

Project Member Reported by dullweber@chromium.org, Jun 2 2017

Issue description

As discussed, we will flip the flag for the new CBD dialog on Android for M60.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d4dfff95b6b22ac3dfac7450396e83a8dcad6e8

commit 6d4dfff95b6b22ac3dfac7450396e83a8dcad6e8
Author: dullweber <dullweber@chromium.org>
Date: Fri Jun 02 12:00:08 2017

Enable TabsInCBD flag for Android. This will enable the new Clear Browsing Data dialog with a basic and advanced tab.

BUG= 728965 

Review-Url: https://codereview.chromium.org/2920973002
Cr-Commit-Position: refs/heads/master@{#476617}

[modify] https://crrev.com/6d4dfff95b6b22ac3dfac7450396e83a8dcad6e8/chrome/common/chrome_features.cc

Summary: Enable TabsInCBD flag for Android (was: Enabled TabsInCBD flag for Android)
Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 5 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Merged on dullweber@'s behalf in https://codereview.chromium.org/2926573002/.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d71adbf0a86d94815f3eacdd50b3f25ab66d32

commit c9d71adbf0a86d94815f3eacdd50b3f25ab66d32
Author: Martin Sramek <msramek@chromium.org>
Date: Tue Jun 06 12:57:45 2017

Enable TabsInCBD flag for Android. This will enable the new Clear Browsing Data dialog with a basic and advanced tab.

BUG= 728965 

Review-Url: https://codereview.chromium.org/2920973002
Cr-Original-Commit-Position: refs/heads/master@{#476617}
Review-Url: https://codereview.chromium.org/2926573002 .
Cr-Commit-Position: refs/branch-heads/3112@{#180}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/c9d71adbf0a86d94815f3eacdd50b3f25ab66d32/chrome/common/chrome_features.cc

Status: Fixed (was: Started)
Thanks!

Sign in to add a comment