Issue metadata
Sign in to add a comment
|
Regression:Overlapping of fav and close icon is observed after installing hangouts app.
Reported by
vku...@etouch.net,
Jun 2 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:61.0.3118.0 (Official Build)Revision e7b341c528a738a53a71ce8f3090f82805557dcc-refs/heads/master@{#476500} (64-bit) OS: Mac (10.12.3,10.11.6) Pre-condition: 1. Select ‘Right-to-left’ option of #Force UI direction flag. 2. Select ‘Right-to-left’ option of #Force text direction flag. 3. Enable RTL Mac flag. What steps will reproduce the problem? (1)Relaunch chrome and open 2-3 webpages. (2)Install 'hangouts' app from https://chrome.google.com/webstore/detail/google-hangouts/knipolnnllmklapflnccelgolnpehhpl?utm_source=chrome-ntp-icon (3)Once chrome://apps page appear after complete installation switch between tab and observe. Actual: Overlapping of fav and close icon is observed after installing hangouts app. Expected: No such overlapping of fav and close icon should be seen after installing hangouts app. This is a regression issue broken in 'M60' and below is the manual regression range Good Build: 60.0.3103.0 Bad Build: 60.0.3104.0 Note: Issue not seen on Win & Linux OS.
,
Jun 6 2017
I think the suspected culprit Cl : https://chromium.googlesource.com/chromium/src/+/89c24d4a46c1f0e7ad03891a659e6d23dc776c36
,
Jun 6 2017
CL has been reverted: https://codereview.chromium.org/2917523002 I don't have a mac setup though. Can you confirm if the issue is resolved with the latest builds? (Related bug: https://bugs.chromium.org/p/chromium/issues/detail?id=727229)
,
Jun 7 2017
Rechecked this on chrome Canary version 61.0.3122.0 on MAC 10.12.5 and the revert is working fine. Issue is no longer observed. Adding TE-verified labels. Thanks.!
,
Jun 15 2017
Able to reproduce the issue on Mac 10.12.5 using chrome version 60.0.3112.24. mbjorge@ If possible please merge the fix to M60 as well. Thanks,
,
Jun 19 2017
,
Jun 19 2017
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/chromium-dev/ZEbgWX_zius/9fll8JKDBwAJ Led me to believe that M60 == Branch 3112 I CP'd the revert to 3112 https://chromium-review.googlesource.com/c/527328/ and it was merged on Jun 14th, so it should be fixed in M60. Can you confirm the build you tested with is from after that point?
,
Jun 27 2017
kavvaru@, please verify this fix on Chrome#60.0.3112.32 or later version of Beta.
,
Jun 28 2017
Tested the issue on Mac 10.12.6 using chrome version 60.0.3112.50 as per the steps mentioned in comment #0.Not seeing any Overlapping of fav and close icon after installing hangouts app. Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks,
,
Jun 28 2017
Closing per TE verification.
,
Jun 28 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 28 2017
Double-checking change logs, etc., before I remove the Merge-TBD label, the revert does seem to have landed on the 3112 branch. https://chromium.googlesource.com/chromium/src/+/eeb12a2d4f56714eafd9e71dba80ca378ace13e9 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Jun 2 2017Owner: ananta@chromium.org
Status: Assigned (was: Unconfirmed)