New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728931 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Auto-always/never can at most trigger twice (new translate infobar)

Project Member Reported by martiw@chromium.org, Jun 2 2017

Issue description

Auto-always/never can at most triggered twice (new translate infobar)

Currently, in the new translate infobar, 
"Always translate" will be triggered automatically when a language
is consecutively translated for 5 times. And user can click on "Cancel"
to undo the "Always translate".

However, it is quite annoying that the auto-always will keep triggering
again and again for every 5 translations.

After discussion, we should limit the maximum number of auto-always to
2 times.

Same for auto-never.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb6d187db2e842f01db923c87d7958b52175c37f

commit fb6d187db2e842f01db923c87d7958b52175c37f
Author: martiw <martiw@chromium.org>
Date: Wed Jun 14 00:28:00 2017

Auto-always/never can at most triggered twice (new translate infobar)

Currently, in the new translate infobar,
"Always translate" will be triggered automatically when a language
is consecutively translated for 5 times. And user can click on "Cancel"
to undo the "Always translate".

However, it is quite annoying that the auto-always will keep triggering
again and again for every 5 translations.

After discussion, we should limit the maximum number of auto-always to
2 times.

Same for auto-never.

BUG= 728931 

Review-Url: https://codereview.chromium.org/2920953002
Cr-Commit-Position: refs/heads/master@{#479226}

[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/chrome/browser/ui/android/infobars/translate_compact_infobar.h
[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_infobar_delegate.h
[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_prefs.h

Comment 3 by martiw@chromium.org, Jun 22 2017

Status: Fixed (was: Started)

Sign in to add a comment