Auto-always/never can at most trigger twice (new translate infobar) |
||
Issue descriptionAuto-always/never can at most triggered twice (new translate infobar) Currently, in the new translate infobar, "Always translate" will be triggered automatically when a language is consecutively translated for 5 times. And user can click on "Cancel" to undo the "Always translate". However, it is quite annoying that the auto-always will keep triggering again and again for every 5 translations. After discussion, we should limit the maximum number of auto-always to 2 times. Same for auto-never.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb6d187db2e842f01db923c87d7958b52175c37f commit fb6d187db2e842f01db923c87d7958b52175c37f Author: martiw <martiw@chromium.org> Date: Wed Jun 14 00:28:00 2017 Auto-always/never can at most triggered twice (new translate infobar) Currently, in the new translate infobar, "Always translate" will be triggered automatically when a language is consecutively translated for 5 times. And user can click on "Cancel" to undo the "Always translate". However, it is quite annoying that the auto-always will keep triggering again and again for every 5 translations. After discussion, we should limit the maximum number of auto-always to 2 times. Same for auto-never. BUG= 728931 Review-Url: https://codereview.chromium.org/2920953002 Cr-Commit-Position: refs/heads/master@{#479226} [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/chrome/browser/ui/android/infobars/translate_compact_infobar.cc [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/chrome/browser/ui/android/infobars/translate_compact_infobar.h [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_infobar_delegate.cc [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_infobar_delegate.h [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/fb6d187db2e842f01db923c87d7958b52175c37f/components/translate/core/browser/translate_prefs.h
,
Jun 22 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by martiw@chromium.org
, Jun 2 2017