factory & region: Deprecate region numerical ID. |
|||||
Issue descriptionPreviously we expect regions to follow same numerical index, so it can share same encoding style in HWID. However, this is causing problems when new regions are going to be added and exceed reserved HWID column. With the change of new "region_field" (that takes an explicit list) in HWID config file, we are now able to simplify the process by supporting only specified regions. This also helps device PM to make sure partners are not building unapproved regions. It is time to deprecate the old style numerical IDs.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/98501aec999d923fadbd03d06c5bf06713553d14 commit 98501aec999d923fadbd03d06c5bf06713553d14 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Jun 06 06:49:38 2017 regions: Remove numeric ID. The numeric ID should have been deprecated. Remove them in region database. Also revised region definition so it visually looks like: Region( REGION_CODE, some settings, ... COUNTRY_NAME, ( NOTES)) And is easier to read when we want to find some countries. Also cleaned up lint warnings and removed dead code. Note that most of the unconfirmed regions were generated by external database (experimental/generator.py) without right locales defined in ChromeOS and have to get a review process before it can be used. BUG= chromium:728924 TEST=./regions_unittest.py Change-Id: I1ce3efcee5a554b7b5df478f7f617a332b2309c3 Reviewed-on: https://chromium-review.googlesource.com/522267 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> [modify] https://crrev.com/98501aec999d923fadbd03d06c5bf06713553d14/regions/experimental/generator.py [modify] https://crrev.com/98501aec999d923fadbd03d06c5bf06713553d14/regions/update_testdata.py [modify] https://crrev.com/98501aec999d923fadbd03d06c5bf06713553d14/regions/regions_unittest.py [modify] https://crrev.com/98501aec999d923fadbd03d06c5bf06713553d14/regions/regions.py
,
Jul 14 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2149739371b7822478ec4fc21eb6854a5298b349 commit 2149739371b7822478ec4fc21eb6854a5298b349 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Oct 31 07:18:49 2017 l10n: Remove numeric ID from region list. Numeric IDs are removed in CL:522267 so we have to stop using it. BUG= chromium:728924 TEST=make test Change-Id: I0874bbce90fb6f66a910661832acab8efaf7b19c Reviewed-on: https://chromium-review.googlesource.com/522186 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/743664 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/2149739371b7822478ec4fc21eb6854a5298b349/py/hwid/v3/yaml_tags.py [modify] https://crrev.com/2149739371b7822478ec4fc21eb6854a5298b349/py/test/l10n/regions_unittest.py [modify] https://crrev.com/2149739371b7822478ec4fc21eb6854a5298b349/py/test/l10n/regions.py
,
Jan 22 2018
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92 commit beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Nov 21 20:58:33 2018 regions: Remove numeric ID. The numeric ID should have been deprecated. Remove them in region database. Also revised region definition so it visually looks like: Region( REGION_CODE, some settings, ... COUNTRY_NAME, ( NOTES)) And is easier to read when we want to find some countries. Also cleaned up lint warnings and removed dead code. Note that most of the unconfirmed regions were generated by external database (experimental/generator.py) without right locales defined in ChromeOS and have to get a review process before it can be used. BUG= chromium:728924 TEST=./regions_unittest.py Change-Id: I1ce3efcee5a554b7b5df478f7f617a332b2309c3 Reviewed-on: https://chromium-review.googlesource.com/522267 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1347140 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92/regions/experimental/generator.py [modify] https://crrev.com/beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92/regions/update_testdata.py [modify] https://crrev.com/beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92/regions/regions_unittest.py [modify] https://crrev.com/beb15dfe1c8bdd334f8a980dc71f966ef9c3ae92/regions/regions.py
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/f4c0226add9452e353ea0cf07a2d3f7571512e70 commit f4c0226add9452e353ea0cf07a2d3f7571512e70 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Nov 22 07:49:46 2018 l10n: Remove numeric ID from region list. Numeric IDs are removed in CL:522267 so we have to stop using it. BUG= chromium:728924 TEST=make test Change-Id: I0874bbce90fb6f66a910661832acab8efaf7b19c Reviewed-on: https://chromium-review.googlesource.com/522186 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1347810 Reviewed-by: Wei-Han Chen <stimim@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> Trybot-Ready: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/f4c0226add9452e353ea0cf07a2d3f7571512e70/py/hwid/v3/yaml_tags.py [modify] https://crrev.com/f4c0226add9452e353ea0cf07a2d3f7571512e70/py/test/l10n/regions_unittest.py [modify] https://crrev.com/f4c0226add9452e353ea0cf07a2d3f7571512e70/py/test/l10n/regions.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 5 2017