Close button doesn't disappear on toast |
||||||
Issue descriptionRepro on 59.0.3071 and ToT. Repro steps: 1. Get a notification that shows as a toast 2. Hover the cursor and see the close button appears 3. Move the cursor out of the notification Actual: The close button keeps visible Expected: The close button disappears This happened only on ARC toasts.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b1b44becb55f7920992b9027307531932f83ce7 commit 7b1b44becb55f7920992b9027307531932f83ce7 Author: yoshiki <yoshiki@chromium.org> Date: Thu Jun 08 09:02:43 2017 Update the button visibility when mouse enters or exits from notification surface window The outer view's ONMOUSEENTERED/EXITED are not called on toast, so we need to handle the window's event handlers. BUG= 728915 TEST=manual (issue is not happened) Review-Url: https://codereview.chromium.org/2922643002 Cr-Commit-Position: refs/heads/master@{#477927} [modify] https://crrev.com/7b1b44becb55f7920992b9027307531932f83ce7/ui/arc/notification/arc_notification_content_view.cc
,
Jun 8 2017
,
Jun 9 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee53fcd185bc5a713a76bda3d8836328e4952426 commit ee53fcd185bc5a713a76bda3d8836328e4952426 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Jun 13 04:37:24 2017 Update the button visibility when mouse enters or exits from notification surface window The outer view's ONMOUSEENTERED/EXITED are not called on toast, so we need to handle the window's event handlers. BUG= 728915 TEST=manual (issue is not happened) Review-Url: https://codereview.chromium.org/2922643002 Cr-Commit-Position: refs/heads/master@{#477927} (cherry picked from commit 7b1b44becb55f7920992b9027307531932f83ce7) Review-Url: https://codereview.chromium.org/2939673002 . Cr-Commit-Position: refs/branch-heads/3112@{#314} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/ee53fcd185bc5a713a76bda3d8836328e4952426/ui/arc/notification/arc_custom_notification_view.cc
,
Jun 14 2017
,
Jun 14 2017
ID:e7558090c3ae4bd7b7c9e9ec445c7e
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yoshiki@chromium.org
, Jun 2 2017