New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728914 link

Starred by 2 users
Status: Archived
Owner:
nya@chromium.org
Closed: Jun 2017
Cc:
vapier@chromium.org
█ ejcaruso@chromium.org
█ josa...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 728184



Sign in to add a comment

container_utils missing dependency to chromeos-base/session_manager-client

Project Member Reported by nya@chromium.org, Jun 2 2017 
platform2/container_utils/container_utils.gyp:

    'variables': {
      'deps': [
        'libchrome-<(libbase_ver)',
        'libsession_manager-client',
      ],
      'enable_exceptions': 1,
    },

third_party/chromiumos-overlay/chromeos-base/container_utils/container_utils-9999.ebuild:

RDEPEND="
        chromeos-base/libbrillo
        device_jail? (
                virtual/udev
                sys-fs/fuse
        )
"
DEPEND="${RDEPEND}"

Breaking change:
https://chromium-review.googlesource.com/505717

This is making BuildPackage stage yellow randomly.  Issue 728184  seems caused by this.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/931be50bebd8aa8ba38bc14f16d4bad756257da1

commit 931be50bebd8aa8ba38bc14f16d4bad756257da1
Author: Shuhei Takahashi <nya@chromium.org>
Date: Fri Jun 02 08:37:27 2017

container_utils: Add missing deps.

BUG= chromium:728914 
TEST=sudo parallel_emerge --board=samus chromeos-base/container_utils

Change-Id: I086fde82e3c34dc779c180613c07fa7a475373cb
Reviewed-on: https://chromium-review.googlesource.com/522265
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/931be50bebd8aa8ba38bc14f16d4bad756257da1/chromeos-base/container_utils/container_utils-9999.ebuild

Comment 2 by nya@chromium.org, Jun 2 2017

Labels: M-60 Merge-Request-60
Status: Fixed (was: Started)

Comment 3 by josa...@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Merge-Approved-60
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 3 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ebf4b8f48a104dd59074662ca798e1bc24f44768

commit ebf4b8f48a104dd59074662ca798e1bc24f44768
Author: Shuhei Takahashi <nya@chromium.org>
Date: Sat Jun 03 00:51:44 2017

container_utils: Add missing deps.

BUG= chromium:728914 
TEST=sudo parallel_emerge --board=samus chromeos-base/container_utils

Change-Id: I086fde82e3c34dc779c180613c07fa7a475373cb
Reviewed-on: https://chromium-review.googlesource.com/522265
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 931be50bebd8aa8ba38bc14f16d4bad756257da1)
Reviewed-on: https://chromium-review.googlesource.com/523283
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/ebf4b8f48a104dd59074662ca798e1bc24f44768/chromeos-base/container_utils/container_utils-9999.ebuild
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 6 2017

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by nya@chromium.org, Jun 6 2017

Labels: -Merge-Approved-60

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment