Paint property under-invalidations |
||||
Issue descriptionThe following tests fail with https://chromium-review.googlesource.com/c/522346/ because of paint property under-invalidation: paint/invalidation/svg/mask-clip-target-transform.svg paint/invalidation/svg/resource-invalidate-on-target-update.svg
,
Jun 2 2017
,
Jun 5 2017
Is this an SPInvalidation bug also? If so we should fix it as a P1.
,
Jun 5 2017
No. They happen on SPv2 only.
,
Sep 13 2017
These paint property under-invalidations will also happen on SPv1 when we enable effect nodes in paint property tree for SPv1.
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276e67482194dc33eaeaa84b4de7a411afe9e7e1 commit 276e67482194dc33eaeaa84b4de7a411afe9e7e1 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Sep 14 22:55:03 2017 Fix under-invalidation of paint properties about mask Bug: 728913 Change-Id: I8ecaff077cc303d1cf3b646a2e7bab3b680acf7e Reviewed-on: https://chromium-review.googlesource.com/666334 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502073} [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/276e67482194dc33eaeaa84b4de7a411afe9e7e1/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
,
Sep 14 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wangxianzhu@chromium.org
, Jun 2 2017