New issue
Advanced search Search tips

Issue 728906 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 694131



Sign in to add a comment

elm/hana: disable ForceBitrate test cases for 320x180 video

Project Member Reported by wuchengli@chromium.org, Jun 2 2017

Issue description

The failure rate of ForceBitrate for 320x180 is around 40% on elm and hana. Since we don't have time to fix it, let's disable it in video_VideoEncodeAccelerator so it won't cover the new regression. Note elm/hana only failed ForceBitrate if the video is 320x180. Please only disable 320x180.

06/01 14:28:51.753 DEBUG|             utils:0298| [stdout] [ RUN      ] ForceBitrate/VideoEncodeAcceleratorTest.TestSimpleEncode/0
06/01 14:28:51.935 DEBUG|             utils:0298| [stdout] ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:1731: Failure
06/01 14:28:51.936 DEBUG|             utils:0298| [stdout] The difference between bitrate and current_requested_bitrate_ is 101147, which exceeds kBitrateTolerance * current_requested_bitrate_, where
06/01 14:28:51.937 DEBUG|             utils:0298| [stdout] bitrate evaluates to 201147,
06/01 14:28:51.938 DEBUG|             utils:0298| [stdout] current_requested_bitrate_ evaluates to 100000, and
06/01 14:28:51.939 DEBUG|             utils:0298| [stdout] kBitrateTolerance * current_requested_bitrate_ evaluates to 10000.
06/01 14:28:52.179 ERROR|             utils:0298| [stderr] [0601/142852.178769:INFO:video_encode_accelerator_unittest.cc(473)] Measured encoder FPS: 1124.065
06/01 14:28:52.195 ERROR|             utils:0298| [stderr] 
06/01 14:28:52.208 DEBUG|             utils:0298| [stdout] ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:1731: Failure
06/01 14:28:52.210 DEBUG|             utils:0298| [stdout] The difference between bitrate and current_requested_bitrate_ is 100269, which exceeds kBitrateTolerance * current_requested_bitrate_, where
06/01 14:28:52.211 DEBUG|             utils:0298| [stdout] bitrate evaluates to 200269,
06/01 14:28:52.212 DEBUG|             utils:0298| [stdout] current_requested_bitrate_ evaluates to 100000, and
06/01 14:28:52.213 DEBUG|             utils:0298| [stdout] kBitrateTolerance * current_requested_bitrate_ evaluates to 10000.
 
Both h264 and vp8 should be disabled.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ffd002943b1d7632b9931a27bffc4cab753d6762

commit ffd002943b1d7632b9931a27bffc4cab753d6762
Author: Pin-chih Lin <johnylin@google.com>
Date: Mon Jun 05 05:09:45 2017

video_VDA: disable ForceBitrate for 320x180 video on elm/hana

BUG= chromium:728906 
TEST=manual test

Change-Id: I7c23980dae6ce529b906a7877c23c011108abccd
Reviewed-on: https://chromium-review.googlesource.com/522307
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/ffd002943b1d7632b9931a27bffc4cab753d6762/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Started (was: Assigned)

Comment 4 by kcwu@chromium.org, Jun 5 2017

Blocking: 694131
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fe96a969226c4ea374a28cfbcb3c6f473950e6c1

commit fe96a969226c4ea374a28cfbcb3c6f473950e6c1
Author: Pin-chih Lin <johnylin@google.com>
Date: Tue Jun 06 01:35:12 2017

video_VDA: disable ForceBitrate for 320x180 video on elm/hana

BUG= chromium:728906 
TEST=manual test

Change-Id: I7c23980dae6ce529b906a7877c23c011108abccd
Reviewed-on: https://chromium-review.googlesource.com/522307
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit ffd002943b1d7632b9931a27bffc4cab753d6762)
Reviewed-on: https://chromium-review.googlesource.com/523903
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/fe96a969226c4ea374a28cfbcb3c6f473950e6c1/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6b3a31583d3937e31e31a1e1580fcbe0ba1f47c5

commit 6b3a31583d3937e31e31a1e1580fcbe0ba1f47c5
Author: Pin-chih Lin <johnylin@google.com>
Date: Thu Jun 08 14:47:34 2017

video_VDA: disable ForceBitrate for 320x180 video on elm/hana

BUG= chromium:728906 
TEST=manual test

Change-Id: I7c23980dae6ce529b906a7877c23c011108abccd
Reviewed-on: https://chromium-review.googlesource.com/522307
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit ffd002943b1d7632b9931a27bffc4cab753d6762)
Reviewed-on: https://chromium-review.googlesource.com/527856
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/6b3a31583d3937e31e31a1e1580fcbe0ba1f47c5/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Assigned (was: Verified)
elm 9662.0.0 still has the failure. Do you know why?

06/18 14:37:43.243 DEBUG|             utils:0212| Running 'HOME=/tmp/tmpl8L0fx CR_SOURCE_ROOT=/usr/local/autotest/deps/chrome_test/test_src CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox GTEST_OUTPUT=xml:/tmp/gtest_xmlflPJJT.xml /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_encode_accelerator_unittest --test_stream_data="/usr/local/autotest/tmp/tmpNBY__r_video_VideoEncodeAccelerator.h264/tulip2-320x180-55be7124b3aec1b72bfb57f433297193.yuv:320:180:1:/usr/local/autotest/tmp/tmpNBY__r_video_VideoEncodeAccelerator.h264/tulip2-320x180-55be7124b3aec1b72bfb57f433297193.yuv.out:100000" --vmodule=*/media/gpu/*video_decode_accelerator.cc=2,*/media/gpu/*video_encode_accelerator.cc=2,*/media/gpu/*jpeg_decode_accelerator.cc=2,*/media/gpu/v4l2_image_processor.cc=2 --ozone-platform=gbm --gtest_filter="-MidStreamParamSwitchBitrate/*:MultipleEncoders/*"'

06/18 14:37:44.558 DEBUG|             utils:0280| [stdout] [----------] 1 test from ForceBitrate/VideoEncodeAcceleratorTest
06/18 14:37:44.559 DEBUG|             utils:0280| [stdout] [ RUN      ] ForceBitrate/VideoEncodeAcceleratorTest.TestSimpleEncode/0
06/18 14:37:44.720 DEBUG|             utils:0280| [stdout] ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:1731: Failure
06/18 14:37:44.721 DEBUG|             utils:0280| [stdout] The difference between bitrate and current_requested_bitrate_ is 101147, which exceeds kBitrateTolerance * current_requested_bitrate_, where
06/18 14:37:44.722 DEBUG|             utils:0280| [stdout] bitrate evaluates to 201147,
06/18 14:37:44.722 DEBUG|             utils:0280| [stdout] current_requested_bitrate_ evaluates to 100000, and
06/18 14:37:44.723 DEBUG|             utils:0280| [stdout] kBitrateTolerance * current_requested_bitrate_ evaluates to 10000.
06/18 14:37:44.890 ERROR|             utils:0280| [stderr] [0618/143744.890377:INFO:video_encode_accelerator_unittest.cc(473)] Measured encoder FPS: 1456.826
06/18 14:37:44.898 ERROR|             utils:0280| [stderr] 
06/18 14:37:44.906 DEBUG|             utils:0280| [stdout] ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/video_encode_accelerator_unittest.cc:1731: Failure

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/124063669-chromeos-test/chromeos2-row7-rack7-host3/debug/
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/271e6e66d9696fefd2ec95600c9533e361ce6c0c

commit 271e6e66d9696fefd2ec95600c9533e361ce6c0c
Author: Pin-chih Lin <johnylin@google.com>
Date: Fri Jun 23 03:12:57 2017

video_VEA: fix gtest_filter overwritten in stream loop

The bug was hit if predefined_filter differs between streams. Keep
gtest_filter as argument from commands and don't overwrite it.

BUG= chromium:728906 
TEST=manual test

Change-Id: I44babb56ba7b63db666011d93b2057e38dd6bf61
Reviewed-on: https://chromium-review.googlesource.com/541177
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 9b9f841a945966b399c30cf8a2e761ab0811f06c)
Reviewed-on: https://chromium-review.googlesource.com/544744
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/271e6e66d9696fefd2ec95600c9533e361ce6c0c/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/824e9b0ff4ae08b5e4c41719e5af0a690236bbaf

commit 824e9b0ff4ae08b5e4c41719e5af0a690236bbaf
Author: Pin-chih Lin <johnylin@google.com>
Date: Fri Jun 23 03:13:08 2017

video_VEA: fix gtest_filter overwritten in stream loop

The bug was hit if predefined_filter differs between streams. Keep
gtest_filter as argument from commands and don't overwrite it.

BUG= chromium:728906 
TEST=manual test

Change-Id: I44babb56ba7b63db666011d93b2057e38dd6bf61
Reviewed-on: https://chromium-review.googlesource.com/541177
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 9b9f841a945966b399c30cf8a2e761ab0811f06c)
Reviewed-on: https://chromium-review.googlesource.com/544745
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/824e9b0ff4ae08b5e4c41719e5af0a690236bbaf/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py

Status: Fixed (was: Started)

Sign in to add a comment