New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Payments] Settings link should link to Autofill settings

Project Member Reported by ma...@chromium.org, Jun 2 2017

Issue description

Data source row link ("settings") should go to autofill settings.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1f6df2403aa8ae7beb0df1fac923add396b41d1

commit c1f6df2403aa8ae7beb0df1fac923add396b41d1
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Jun 02 13:50:02 2017

[Payments] Link to Autofill settings from Payment Request UI

Bug:  728873 
Test: Manual
Change-Id: Iaad231a4765de170d9ac287ab89e08a3833b8c45
Reviewed-on: https://chromium-review.googlesource.com/521910
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476629}
[modify] https://crrev.com/c1f6df2403aa8ae7beb0df1fac923add396b41d1/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Comment 2 by ma...@chromium.org, Jun 2 2017

Labels: Merge-Request-60
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 3 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db84bc1dc33c042129f00bf323675cdb0ddc2342

commit db84bc1dc33c042129f00bf323675cdb0ddc2342
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Jun 05 12:43:32 2017

[Merge M60][Payments] Link to Autofill settings from Payment Request UI

Bug:  728873 
Test: Manual
Change-Id: Iaad231a4765de170d9ac287ab89e08a3833b8c45
Reviewed-on: https://chromium-review.googlesource.com/521910
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476629}
Review-Url: https://codereview.chromium.org/2921223003 .
Cr-Commit-Position: refs/branch-heads/3112@{#143}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/db84bc1dc33c042129f00bf323675cdb0ddc2342/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
If this needs to be verified manually, could some one please help us with the steps so as to verify it.

Thanks.!
On Linux, Window, ChromeOS, and Mac:

1) Open https://rsolomakhin.github.io/pr/
2) Click "Buy" on the page.
3) Verify: Clicking on "Settings" link in the dialog opens up Chrome's autofill settings page. (chrome://settings/autofill)
Labels: -Needs-Feedback TE-Verified-M60 TE-Verified-60.0.3112.20
Rechecked this on chrome version 60.0.3112.20 using Windows 10, MAC 10.12.5, Ubuntu 14.04 and CrOS - Peppy (4389.117.0) as per the above steps provided and fix is working as intended. Adding TE-verified labels.

Thanks.!
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment