New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728872 link

Starred by 1 user
Status: Verified
Owner:
isherman@chromium.org
Closed: Oct 2017
Cc:
asvitk...@chromium.org
skare@chromium.org
isherman@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Histogram format errors are failing to block the CQ

Project Member Reported by isherman@chromium.org, Jun 2 2017 
For example, https://codereview.chromium.org/2907153006 landed despite a presubmit warning, "The src directory requires source formatting. Please run git cl format ." [1]  Perhaps we need to upgrade this warning to an error?

[1] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F451574%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout

Comment 1 by asvitk...@chromium.org, Oct 10 2017

Cc: asvitk...@chromium.org
Owner: isherman@chromium.org
Hey Ilya,

You did some work on this front right - can you confirm that this is now resolved and we can close the bug?

Comment 2 by isherman@chromium.org, Oct 27 2017

Status: Verified (was: Assigned)
I tested out the behavior in [ https://chromium-review.googlesource.com/c/chromium/src/+/741085 ].  The presubmit bot correctly failed, with the following error message:

* Presubmit ERRORS **
histograms.xml is not formatted correctly; please run git cl format /b/build/slave/linux/build/src/tools/metrics/histograms to fix.
►

Sign in to add a comment