New issue
Advanced search Search tips

Issue 728866 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

chooseDesktopMedia: customize the order of the picker tabs.

Project Member Reported by braveyao@chromium.org, Jun 1 2017

Issue description

Currently when using multiple sources specified in DesktopCaptureSource the 
window picker will always display the Desktop option first, followed by window, followed by tabs.
An app might want to promote another type of sharing. So let the ordering in theDesktopCaptureSource array determine the ordering of the picker tabs.

 
Labels: -Pri-3 M-61 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ec1444165dcb7f1416251d634e43b1950d1e20

commit 35ec1444165dcb7f1416251d634e43b1950d1e20
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jun 08 20:57:29 2017

Cleanup NativeDesktopMediaList to support only a single capturer.

Previously NativeDesktopMediaList could contain both screens and
windows. Is is no longer necessary because the UI was refactored to
show screens and lists in separate tabs.

Bug:  728866 
Change-Id: I3e58de9cf76629423ee5487ef6f8de07e8f3391d
Reviewed-on: https://chromium-review.googlesource.com/527713
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478081}
[modify] https://crrev.com/35ec1444165dcb7f1416251d634e43b1950d1e20/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/35ec1444165dcb7f1416251d634e43b1950d1e20/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/35ec1444165dcb7f1416251d634e43b1950d1e20/chrome/browser/media/webrtc/native_desktop_media_list.h
[modify] https://crrev.com/35ec1444165dcb7f1416251d634e43b1950d1e20/chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b56f52520d315ee8eb59bb39f97329b0d6c27a70

commit b56f52520d315ee8eb59bb39f97329b0d6c27a70
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jun 09 20:03:12 2017

Update DesktopMediaListAsh to show only windows or only screens

Windows and Screens are shown in separate views in the desktop capture
picker UI, so we no longer need both types of sources in a single list.

Bug:  728866 
Change-Id: I96df72f2920b0b5b9ebc3bbc6adef1ef939a1a64
Reviewed-on: https://chromium-review.googlesource.com/527772
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478385}
[modify] https://crrev.com/b56f52520d315ee8eb59bb39f97329b0d6c27a70/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/b56f52520d315ee8eb59bb39f97329b0d6c27a70/chrome/browser/media/webrtc/desktop_media_list_ash.cc
[modify] https://crrev.com/b56f52520d315ee8eb59bb39f97329b0d6c27a70/chrome/browser/media/webrtc/desktop_media_list_ash.h
[modify] https://crrev.com/b56f52520d315ee8eb59bb39f97329b0d6c27a70/chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb1aef0865be84fa6c19fac640118bb97b6daf33

commit bb1aef0865be84fa6c19fac640118bb97b6daf33
Author: Weiyong Yao <braveyao@chromium.org>
Date: Mon Jun 12 19:25:58 2017

chooseDesktopMedia: Add source type to DesktopMediaList

This is a prerequisite cl for the feature to customize the order of picker Tabs.
By adding source type to DesktopMediaList, the DesktopMediaList users can know
the type (screen/window/tab) of the list and do the relevent processing.

Bug:  728866 
Change-Id: I73ecb3034ce1860bf7d76c6259325813daaa9cf7
Reviewed-on: https://chromium-review.googlesource.com/526854
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478715}
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/desktop_media_list.h
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/desktop_media_list_ash.cc
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/desktop_media_list_ash.h
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/desktop_media_list_base.cc
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/desktop_media_list_base.h
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/fake_desktop_media_list.cc
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/fake_desktop_media_list.h
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/native_desktop_media_list.cc
[modify] https://crrev.com/bb1aef0865be84fa6c19fac640118bb97b6daf33/chrome/browser/media/webrtc/tab_desktop_media_list.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11

commit 7af38200a094aa7e5c58e7f4d56bfdd2ba806f11
Author: Weiyong Yao <braveyao@chromium.org>
Date: Thu Jun 22 18:32:42 2017

chooseDesktopMedia: customize the order of the picker tabs.

Currently when using multiple sources specified in
DesktopCaptureSource the window picker will always display the Desktop
option first, followed by window, followed by tabs.
An app might want to promote another type of sharing. So let the
ordering in the DesktopCaptureSource array determine the ordering of
the picker tabs.

Bug:  728866 
Change-Id: I582db0d6066c59fe92505a1e9dc45ee090366279
Reviewed-on: https://chromium-review.googlesource.com/524038
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481611}
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/media/webrtc/desktop_media_picker.h
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/media/webrtc/fake_desktop_media_list.cc
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/media/webrtc/fake_desktop_media_list.h
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller_unittest.mm
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc
[modify] https://crrev.com/7af38200a094aa7e5c58e7f4d56bfdd2ba806f11/chrome/common/extensions/api/desktop_capture.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e823529023afd62deadf57663688448492bc1e88

commit e823529023afd62deadf57663688448492bc1e88
Author: Weiyong Yao <braveyao@chromium.org>
Date: Tue Jun 27 23:50:05 2017

desktop_capture: simplify source_lists creation logic

This is a following up cl to some comments in
https://chromium-review.googlesource.com/c/524038/.

This cl is to build a std::vector<std::unique_ptr<DesktopMediaList>>
directly in one for loop. And refacor the apitest file accordingly.

Bug:  728866 
Change-Id: I82698a6822baff0705db39db6f182b6158dcd473
Reviewed-on: https://chromium-review.googlesource.com/546775
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482798}
[modify] https://crrev.com/e823529023afd62deadf57663688448492bc1e88/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/e823529023afd62deadf57663688448492bc1e88/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/e823529023afd62deadf57663688448492bc1e88/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h

Status: Fixed (was: Assigned)

Sign in to add a comment