Add timeouts for heartbeat timeouts in chromoting host |
||
Issue descriptionCurrently heartbeats never timeout, which makes it harder to detect a broken XMPP connection.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec73fbda2ecc517050f99d91fa1394226a7c322 commit dec73fbda2ecc517050f99d91fa1394226a7c322 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Jun 16 06:46:26 2017 Cleanup HeartbeatSender to handle all errors consistenly. Previosuly HeartbeatSender had two separate timers for periodic heartbeats and for retries. Exponential backoff logic was applied only for some errors. Now timer scheduling is handled in the same place for all errors to make it consistent and easier to understand. Also cleaned up unittests to avoid dependency on the internal details of the implementation. BUG= 728851 Change-Id: I5b5df999d9aa9412e1c83637959c9d6c5a2cd84d Reviewed-on: https://chromium-review.googlesource.com/536393 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#479970} [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender.cc [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender.h [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender_unittest.cc [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/protocol/jingle_session_unittest.cc [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/signaling/fake_signal_strategy.cc [modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/signaling/fake_signal_strategy.h
,
Jun 19 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 2 2017