New issue
Advanced search Search tips

Issue 728851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add timeouts for heartbeat timeouts in chromoting host

Project Member Reported by sergeyu@chromium.org, Jun 1 2017

Issue description

Currently heartbeats never timeout, which makes it harder to detect a broken XMPP connection.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6e12e26514866f3e92bfed8725a3338f0e4409c

commit b6e12e26514866f3e92bfed8725a3338f0e4409c
Author: sergeyu <sergeyu@chromium.org>
Date: Fri Jun 02 19:11:35 2017

Add heartbeat timeout.

Added timeout for outgoing messages in remoting::HeartbeatSender.
XMPP connection is reset after 2 timed out heartbeats.

Also updated the class and the unittest to use constexpr TimeDelta
for all time constants.

BUG= 728851 

Review-Url: https://codereview.chromium.org/2915193003
Cr-Commit-Position: refs/heads/master@{#476744}

[modify] https://crrev.com/b6e12e26514866f3e92bfed8725a3338f0e4409c/remoting/host/heartbeat_sender.cc
[modify] https://crrev.com/b6e12e26514866f3e92bfed8725a3338f0e4409c/remoting/host/heartbeat_sender.h
[modify] https://crrev.com/b6e12e26514866f3e92bfed8725a3338f0e4409c/remoting/host/heartbeat_sender_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec73fbda2ecc517050f99d91fa1394226a7c322

commit dec73fbda2ecc517050f99d91fa1394226a7c322
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jun 16 06:46:26 2017

Cleanup HeartbeatSender to handle all errors consistenly.

Previosuly HeartbeatSender had two separate timers for periodic
heartbeats and for retries. Exponential backoff logic was applied only
for some errors. Now timer scheduling is handled in the same place for
all errors to make it consistent and easier to understand.

Also cleaned up unittests to avoid dependency on the internal details
of the implementation.

BUG= 728851 

Change-Id: I5b5df999d9aa9412e1c83637959c9d6c5a2cd84d
Reviewed-on: https://chromium-review.googlesource.com/536393
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479970}
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender.cc
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender.h
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/host/heartbeat_sender_unittest.cc
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/protocol/jingle_session_unittest.cc
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/signaling/fake_signal_strategy.cc
[modify] https://crrev.com/dec73fbda2ecc517050f99d91fa1394226a7c322/remoting/signaling/fake_signal_strategy.h

Status: Fixed (was: Started)

Sign in to add a comment