The code in network_menu.cc was used by the pre MD OOBE UI. It is very old and difficult to maintain, we should remove it as soon as we remove the old OOBE UI.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43da8c877ece944d2bcf957c78e30f6bf803a337 commit 43da8c877ece944d2bcf957c78e30f6bf803a337 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 18 22:41:49 2018 Elim network_menu and network_dropdown This CL removes the unused network_dropdown.js and related C++ support classes including network_menu.cc. It also includes some related cleanup. Bug: 689198 , 728806 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb1e97ce4c4308874f8c977f4d6290a0d91bf15d Reviewed-on: https://chromium-review.googlesource.com/1083173 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568205} [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/chromeos/login/screens/error_screen.cc [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/chromeos/login/screens/error_screen.h [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/chromeos/status/DEPS [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/chromeos/status/network_menu.cc [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/chromeos/status/network_menu.h [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/resources/chromeos/keyboard/keyboard_utils.js [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/resources/chromeos/login/login_non_lock_shared.html [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/resources/chromeos/login/login_non_lock_shared.js [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/resources/chromeos/login/network_dropdown.css [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/resources/chromeos/login/network_dropdown.js [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/DEPS [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/error_screen_handler.h [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc [delete] https://crrev.com/d23f70bf0c8fb72521a5609a6df193ca377054d5/chrome/browser/ui/webui/chromeos/login/network_dropdown.h [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/43da8c877ece944d2bcf957c78e30f6bf803a337/ui/login/display_manager.js
Comment 1 by steve...@chromium.org
, Aug 16 2017