Eliminate disable-md-oobe and remove stale code |
|||||||||||||||||||
Issue descriptionOnce we are fully committed to the MD OOBE UI, we should eliminate the disable-md-oobe switch and any code associated with the old OOBE UI. Maintaining the old code is expensive and is likely to break soon anyway.
,
Aug 1 2017
we're still using pre-MD oobe for "remora" and "shark requisition". I don't really know what these are. The code comments and bug 647411 suggest the only thing stopping us from making the switch for those configurations is testing.
,
Aug 1 2017
The remora requisition is used by CfMs, so we can't quite get rid of the code till we have switched those screens also.
,
Aug 1 2017
Believe Shark requisition was from old proto-ARC++ work on Minnie and is now obsolete. That should move to new UI as part of crbug/709261
,
Aug 1 2017
,
Aug 14 2017
,
Aug 31 2017
,
Oct 19 2017
,
Oct 19 2017
What would be required to move the CfMs to the MD OOBE? Is it realistic to get this into M63 at this point in time? (one week left until beta promotion) Should we perhaps push this to M64?
,
Oct 19 2017
This isn't going to be 63 but let's make sure we do this for 64.
,
Oct 19 2017
CfM should already run MD OOBE.
,
Oct 19 2017
Ah - cool, then let us aim at getting this cleanup into 64.
,
Oct 23 2017
,
Oct 25 2017
,
Dec 4 2017
Felix said it is not hotrod related.
,
Dec 7 2017
M64 beta is targeted for next Tuesday (12-Dec); anything we can do to close this out (exa: tag as fixed) and/or retag as stable block is appreciated. I'll ping the owner as well. Thanks!
,
Dec 11 2017
Please re-evaluate today (Monday, 11-Dec) re: Beta Blocker Status. We're targeting Beta for tomorrow, so please update if a) this isn't blocking, b) the impacted boards can be identified, c) this is resolved / not reproducible, d) a merge / fix can be submitted today. Thanks!
,
Dec 12 2017
Punting this to M65. It should not block beta though I understand the RBB was to ensure that this gets done, but M64 goes beta this week.
,
Dec 12 2017
This doesn't need to be RBB. RBS is fine.
,
Feb 9 2018
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8dbd10b46963d4658900cbd5e05d005d4731ab4 commit c8dbd10b46963d4658900cbd5e05d005d4731ab4 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Feb 09 01:43:06 2018 Chrome OS: Remove --disable-md-oobe command-line option. Bug: 728805, 810594 Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38 Reviewed-on: https://chromium-review.googlesource.com/910317 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#535615} [modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chromeos/chromeos_switches.cc [modify] https://crrev.com/c8dbd10b46963d4658900cbd5e05d005d4731ab4/chromeos/chromeos_switches.h
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867 commit b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Feb 09 02:34:57 2018 Revert "Chrome OS: Remove --disable-md-oobe command-line option." This reverts commit c8dbd10b46963d4658900cbd5e05d005d4731ab4. Reason for revert: Screen is needed on ToT. Original change's description: > Chrome OS: Remove --disable-md-oobe command-line option. > > Bug: 728805, 810594 > Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38 > Reviewed-on: https://chromium-review.googlesource.com/910317 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535615} TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org Change-Id: I76fa4d99f9140ae4df139557cfcb4264ec8e0251 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 728805, 810594 Reviewed-on: https://chromium-review.googlesource.com/910045 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#535616} [modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chromeos/chromeos_switches.cc [modify] https://crrev.com/b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867/chromeos/chromeos_switches.h
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0 commit f1587beaa62e07d1575de51f33f8ddb2f13ea6c0 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Feb 09 02:35:53 2018 Revert "Revert "Chrome OS: Remove --disable-md-oobe command-line option."" This reverts commit b6dc276e6d9bc6cf7bcedb8ad8b2883d9581c867. Reason for revert: Incorrect revert. Original change's description: > Revert "Chrome OS: Remove --disable-md-oobe command-line option." > > This reverts commit c8dbd10b46963d4658900cbd5e05d005d4731ab4. > > Reason for revert: Screen is needed on ToT. > > Original change's description: > > Chrome OS: Remove --disable-md-oobe command-line option. > > > > Bug: 728805, 810594 > > Change-Id: I759cd54222c4fcf2cac5fe6032e8c12bd4a3bb38 > > Reviewed-on: https://chromium-review.googlesource.com/910317 > > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#535615} > > TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org > > Change-Id: I76fa4d99f9140ae4df139557cfcb4264ec8e0251 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 728805, 810594 > Reviewed-on: https://chromium-review.googlesource.com/910045 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#535616} TBR=stevenjb@chromium.org,achuith@chromium.org,alemate@chromium.org Change-Id: Ie979d28089e457af300e86c7a7caaa870c03e297 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 728805, 810594 Reviewed-on: https://chromium-review.googlesource.com/910046 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#535617} [modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chromeos/chromeos_switches.cc [modify] https://crrev.com/f1587beaa62e07d1575de51f33f8ddb2f13ea6c0/chromeos/chromeos_switches.h
,
Feb 9 2018
Moving code removal part to next release per offline discussion with Steven.
,
Mar 7 2018
Command-line option is removed, so it is not blocking stable anymore. Code cleanup will happen eventually.
,
Mar 27 2018
Is 'eventually' still targeting 67? This is blocking some other cleanup that I hope to do early in the 68 cycle.
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/780fb23ad32a58754c87624a2cb08cf15e193ef5 commit 780fb23ad32a58754c87624a2cb08cf15e193ef5 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Mar 30 08:59:41 2018 Chrome OS: Remove disable-md-error-screen command-line option and code. This removes disable-md-error-screen code that handles it. BUG=728805 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I928d9e874560769811ea004602cee8c308da1765 Reviewed-on: https://chromium-review.googlesource.com/983009 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547132} [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/resources/chromeos/login/oobe_buttons.js [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/resources/chromeos/login/screen_error_message.css [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/resources/chromeos/login/screen_error_message.html [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/resources/chromeos/login/screen_error_message.js [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chromeos/chromeos_switches.cc [modify] https://crrev.com/780fb23ad32a58754c87624a2cb08cf15e193ef5/chromeos/chromeos_switches.h
,
May 5 2018
Alexander, is any of the pre-MD code still used, or can it all be removed?
,
May 5 2018
There are a lot of code still in use. Is there any particular code that you want to remove right now?
,
May 22 2018
,
Aug 1
,
Nov 9
Removing owner and marking available until someone has time to take this on. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by steve...@chromium.org
, Jun 1 2017