New issue
Advanced search Search tips

Issue 728802 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

AVDACodecImage::most_recent_bounds_ are never reset

Project Member Reported by tguilbert@chromium.org, Jun 1 2017

Issue description

When overlays are enabled, on Nexus 5 devices, upon exiting and re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets most_recent_bounds_ when a new overlay is received. This means AndroidOverlay::ScheduleLayout is never called in AVDACodecImage::ScheduleOverlayPlane, and new overlays retains their initial bounds of [0,0,1,1].
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1fdad9d1437cad3bcdc373c02fbc10f7704252e

commit d1fdad9d1437cad3bcdc373c02fbc10f7704252e
Author: tguilbert <tguilbert@chromium.org>
Date: Fri Jun 02 02:18:12 2017

Reset |most_recent_bounds_| on new Overlay

When overlays are enabled, on Nexus 5 devices, upon exiting and
re-entering fullscreen, nothing is displayed on screen.

This is caused by the fact that AVDACodecImage never resets
|most_recent_bounds_| when a new overlay is received. This means
AndroidOverlay::ScheduleLayout() is never called in
AVDACodecImage::ScheduleOverlayPlane(), and new overlays retains their
initial bounds of [0,0,1,1].

This CL fixes the issue by reseting the bounds when a new shared state
(and therefore potential new Overlay) is set.

BUG= 728802 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2916193002
Cr-Commit-Position: refs/heads/master@{#476524}

[modify] https://crrev.com/d1fdad9d1437cad3bcdc373c02fbc10f7704252e/media/gpu/avda_codec_image.cc

Status: Fixed (was: Assigned)

Sign in to add a comment