New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728785 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

browse:media:flickr_infinite_scroll failing on most platforms

Project Member Reported by martiniss@chromium.org, Jun 1 2017

Issue description

system_health.memory_mobile failing on chromium.perf/Android Nexus7v2 Perf

Builders failed on: 
- Android Nexus7v2 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf

https://chromium-swarm.appspot.com/task?id=367ce3de90d62710&refresh=10&show_raw=1 is an example task. It looks like a story is failing on this bot for some reason.
https://chromium-swarm.appspot.com/task?id=367bdc074db85410&refresh=10&show_raw=1 is another example.

flickr seems to be failing for some reason. Not exactly sure why. Screenshot doesn't show much (https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_18-2017-06-01_15-50-0719795.png)
 
Summary: browse:media:flickr_infinite_scroll failing on most platforms (was: system_health.memory_mobile failing on chromium.perf/Android Nexus7v2 Perf)
Yep this story has been failing on most platforms since it got added.

                      config  build               history
0    win-7-nvidia-gpu common    823  111111~~~~~~~~~~~~~~
1     win-7-intel-gpu common    848  111111~~~~~~~~~~~~~~
2       win-7-ati-gpu common    807  111~~~~~~~~~~~~~~~~~
3     win-10-high-dpi common    662  11~1~~~~~~~~~~~~~~~~
4           win-7-x64 common    799  11--1~~~~~~~~~~~~~~~
5  mac-mini-8gb-10.12 common   1628  11---1~~~~~~~~~~~~~~
6           mac-10.12 common    552  1--11-~~~~~~~~~~~~~~
7           mac-10.12 memory    552  111111~~~~~~~~~~~~~~
8  mac-mini-8gb-10.12 memory   1628  11111-~~~~~~~~~~~~~~
9    android-nexus7v2 memory     86  ?1111?1~~~~~~~~~~~~~

I also think it's causing critical failures (aborts and prevents the remaining the stories to run).

I'm going to start disabling and investigate a bit more ...
Cc: u...@chromium.org
Ok, yep, the exception is scrolling getting stuck again:

Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 90, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 296, in RunStory
    self._current_page.Run(self)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 112, in Run
    self.RunPageInteractions(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/system_health_story.py", line 138, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 818, in _DidLoadDocument
    self._Scroll(action_runner, self.SCROLL_DISTANCE, self.SCROLL_STEP)
  File "/b/swarming/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 839, in _Scroll
    raise Exception('Scrolling stuck at %d' % remaining)
Exception: Scrolling stuck at 1500

Also we should be raising there a bare exception, that's what brings down the whole benchmark. I'll fix than one too.
s/we should/we shouldn't/
Cc: hjd@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df637aba4c300a651cd8934f59bf8d48760f8ef

commit 6df637aba4c300a651cd8934f59bf8d48760f8ef
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Fri Jun 02 16:07:17 2017

[tools/perf] Disable browse:media:flickr_infinite_scroll on most platforms

Story is failing and causing critical failures on the benchmark it runs.

NOTRY=True
TBR=nednguyen@google.com,ulan@chromium.org

Bug:  728785 
Change-Id: Ia25f12ab7c567494e9e427c9bf89b7b4a08ae933
Reviewed-on: https://chromium-review.googlesource.com/522688
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476680}
[modify] https://crrev.com/6df637aba4c300a651cd8934f59bf8d48760f8ef/tools/perf/page_sets/system_health/expectations.py

Cc: nednguyen@chromium.org charliea@chromium.org
 Issue 729089  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0221f193ff2027ee5eaf39fb8e9b5f728a23b6

commit 0e0221f193ff2027ee5eaf39fb8e9b5f728a23b6
Author: Vincent Scheib <scheib@chromium.org>
Date: Sat Jun 03 03:03:57 2017

Disable twitter_infinite_scroll & flickr_infinite_scroll

Failing still on multiple platforms.

Previous disabled on only some platforms in
commit 6df637aba4c300a651cd8934f59bf8d48760f8ef
commit 851b9016ee273f0d3cef7eaab1cd2d1e58fc93a2

TBR=scheib@chromium.org

Bug:  728785 ,  728934 ,  724262 
Change-Id: I2cdccb0fa5e1f9287edd59ef2f0519284f3787f5
Reviewed-on: https://chromium-review.googlesource.com/523039
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476878}
[modify] https://crrev.com/0e0221f193ff2027ee5eaf39fb8e9b5f728a23b6/tools/perf/page_sets/system_health/expectations.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dd4910a63995f32f6446b69a4d3c615a8905b82

commit 1dd4910a63995f32f6446b69a4d3c615a8905b82
Author: Juan A. Navarro Perez <perezju@chromium.org>
Date: Sun Jun 04 18:40:16 2017

[tools/perf] Raise StoryActionError when stuck at infinite scroll

Currently the code raises a bare "Exception", which causes the rest of
the benchmark to be aborted.

Rausing instead a StoryActionError causes only the current story to
fail.

Depends on: https://codereview.chromium.org/2922593004

NOTRY=True

Bug:  728785 
Change-Id: Ibc597674317620e612931d702c7d8122fcb9721b
Reviewed-on: https://chromium-review.googlesource.com/522071
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#476912}
[modify] https://crrev.com/1dd4910a63995f32f6446b69a4d3c615a8905b82/tools/perf/page_sets/system_health/browsing_stories.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1466a707d3d4bc35f3bfa38169820edf9ee6060

commit e1466a707d3d4bc35f3bfa38169820edf9ee6060
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jul 07 22:09:18 2017

[system_health] Reenable browse:media:flickr_infinite_scroll story

Bug:728785
Change-Id: Ia7e9a7c1739be25c9f32ab88262b075d553ec535

After the fix to scrolling retry logic in https://chromium-review.googlesource.com/c/563340/, I
can run this test multiple time on my Mac without flakes. So this is probably fixed.

TBR=ulan@chromium.org, perezju@chromium.org

Change-Id: Ia7e9a7c1739be25c9f32ab88262b075d553ec535
Reviewed-on: https://chromium-review.googlesource.com/563527
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#485066}
[modify] https://crrev.com/e1466a707d3d4bc35f3bfa38169820edf9ee6060/tools/perf/page_sets/system_health/expectations.py

Owner: nedngu...@google.com
Status: Fixed (was: Available)
No flakiness report, so I guess this is fixed.
Components: Speed>Benchmarks
\o/
Cc: yoichio@chromium.org
 Issue 728934  has been merged into this issue.

Sign in to add a comment