New issue
Advanced search Search tips

Issue 728779 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-XR



Sign in to add a comment

Automate VR Browser Manual Tests

Project Member Reported by bsheedy@chromium.org, Jun 1 2017

Issue description

Currently, a lot of the VR browser manual tests are to make sure that various features that are supposed to be disabled in VR don't appear while in VR, don't cause crashes, etc.

These should be reasonably easy to automate with the VR E2E test framework, at least to test for crashes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2e2882e49745120243cdcfc311211f4d0dfb4c

commit 3e2e2882e49745120243cdcfc311211f4d0dfb4c
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Jul 12 17:15:08 2017

Add horizontal scrolling to VR browser scrolling test

Adds horizontal scrolling to the VR browser scrolling test, so now both
vertical and horizontal scrolling using the Daydream controller are
tested.

This should hopefully be good enough to remove the need to manually test
basic scroll functionality.

Bug:  728779 
Change-Id: I882755999485b6610fcd865953cb1b06ca47edd5
Reviewed-on: https://chromium-review.googlesource.com/567033
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486003}
[modify] https://crrev.com/3e2e2882e49745120243cdcfc311211f4d0dfb4c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
[modify] https://crrev.com/3e2e2882e49745120243cdcfc311211f4d0dfb4c/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
[add] https://crrev.com/3e2e2882e49745120243cdcfc311211f4d0dfb4c/chrome/test/data/android/webvr_instrumentation/html/test_controller_scrolling.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604301415a66f8cc62fda5bd67962179ffeefe75

commit 604301415a66f8cc62fda5bd67962179ffeefe75
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jul 17 17:21:17 2017

Add VR e2e tests for controller app button

Adds two VR instrumentation tests to check that pressing the Daydream
controller's "app" button causes the browser to exit WebVR presentation
and fullscreen.

Bug:  742569 ,  728779 
Change-Id: I11b92d876875e6224b30b0d5eab498786f698fbf
Reviewed-on: https://chromium-review.googlesource.com/571387
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487131}
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
[modify] https://crrev.com/604301415a66f8cc62fda5bd67962179ffeefe75/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d204dcc2f166bb1f690097aa935351b392630be7

commit d204dcc2f166bb1f690097aa935351b392630be7
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Jul 17 20:02:04 2017

Add history testing code to VR navigation test

Checks browser history after navigating to two pages in the VR browser. Both
the VR browser and regular "2D" Chrome are supposed to share history, which
up until now was only tested manually.

Bug:  728779 
Change-Id: I48b3c075e9a043c9a2fadb67e71e9080cb9f7e9b
Reviewed-on: https://chromium-review.googlesource.com/570120
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487209}
[modify] https://crrev.com/d204dcc2f166bb1f690097aa935351b392630be7/chrome/android/BUILD.gn
[modify] https://crrev.com/d204dcc2f166bb1f690097aa935351b392630be7/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
[modify] https://crrev.com/d204dcc2f166bb1f690097aa935351b392630be7/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
[modify] https://crrev.com/d204dcc2f166bb1f690097aa935351b392630be7/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryPage.java
[modify] https://crrev.com/d204dcc2f166bb1f690097aa935351b392630be7/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java

Components: -UI>Browser>VR Internals>VR
Labels: -Proj-VR-Shell Proj-VR VR-Test
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Brian (as he's working on this), and updating labels/component.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef0ed1c9b77f8fad0a16f8717bf4b2f0d0791b6

commit aef0ed1c9b77f8fad0a16f8717bf4b2f0d0791b6
Author: bsheedy <bsheedy@chromium.org>
Date: Sat Aug 12 00:38:02 2017

Add automated test for WebVR visibility without flag

Automates one of our manual test cases that checks that the WebVR API
is not visible on webpages when both:
1. The flag to enable WebVR is not explicitly set
2. The page does not have a WebVR origin trial token

Bug: 753540,  728779 
Change-Id: I8aed5638a808d8a0ef9170795194cb85f7c2b754
Reviewed-on: https://chromium-review.googlesource.com/610643
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493905}
[modify] https://crrev.com/aef0ed1c9b77f8fad0a16f8717bf4b2f0d0791b6/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
[add] https://crrev.com/aef0ed1c9b77f8fad0a16f8717bf4b2f0d0791b6/chrome/test/data/android/webvr_instrumentation/html/test_webvr_disabled_without_flag_set.html

I think this should be closed out in favor of creating individual issues for manual tests we want to automate. Otherwise, this will pretty much never be fixed.
Status: WontFix (was: Assigned)
Components: Internals>XR

Sign in to add a comment