web_resource::ResourceRequestAllowedNotifier::Observer should define a virtual destructor. |
||||||
Issue descriptionThis came up as part of https://codereview.chromium.org/2894483003 and can lead to undefined behavior.
,
Jun 29 2017
,
Jul 11 2017
,
Aug 25 2017
,
Sep 25 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0497eba55b0c8dcf1fb0e365210f743d72341f commit 9b0497eba55b0c8dcf1fb0e365210f743d72341f Author: Eugene But <eugenebut@google.com> Date: Tue Sep 26 16:36:59 2017 Added virtual destructor to ResourceRequestAllowedNotifier::Observer. Bug: 728776 Change-Id: Id135e60fb228a664fe456d74ce1b60752d6eb7dc Reviewed-on: https://chromium-review.googlesource.com/682015 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#504393} [modify] https://crrev.com/9b0497eba55b0c8dcf1fb0e365210f743d72341f/chrome/browser/translate/translate_service.h [modify] https://crrev.com/9b0497eba55b0c8dcf1fb0e365210f743d72341f/components/web_resource/resource_request_allowed_notifier.h [modify] https://crrev.com/9b0497eba55b0c8dcf1fb0e365210f743d72341f/ios/chrome/browser/translate/translate_service_ios.h [modify] https://crrev.com/9b0497eba55b0c8dcf1fb0e365210f743d72341f/ios/web_view/internal/translate/web_view_translate_service.h
,
Sep 26 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by edchin@chromium.org
, Jun 5 2017Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)