[MD settings] use unfiltered embeddingOrigin in site exceptions |
||
Issue descriptionin chrome://settings/content/* (e.g. notifications) If an exception has an embeddingOrigin it is filtered and obfuscated. I believe this was due to an earlier attempt to make these advanced features more user friendly. Altering (simplifying) the data is insufficient to make the feature simple and it breaks the advanced user's ability to clearly see the effects of the exceptions. Suggestion: remove the displayEmbeddingOrigin and use the unfiltered embeddingOrigin directly.
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb2ef31906237103697cb5ed600386e9b887f625 commit cb2ef31906237103697cb5ed600386e9b887f625 Author: dschuyler <dschuyler@chromium.org> Date: Wed Jun 28 23:35:11 2017 [MD settings] site exceptions, use embedding origin rather than embeddingDisplayName This CL removes the displayEmbeddingOrigin member and derives a display name from the embeddingOrigin value instead. BUG= 728774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919853002 Cr-Commit-Position: refs/heads/master@{#483197} [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/app/settings_strings.grdp [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/browser/resources/settings/site_settings/site_list.js [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/browser/resources/settings/site_settings/site_settings_behavior.js [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/cb2ef31906237103697cb5ed600386e9b887f625/chrome/test/data/webui/settings/site_list_tests.js
,
Jul 1 2017
The CL above grouped the generation of the secondary description line into one place, which is a good step forward code-wise. It didn't change the UI though. In that CL msramek@ said, "I would still spell it out for the user, especially since we're already verbose with the Incognito part anyway." So maybe the initial intent of this bug is a wontFix. msramek@ went on to say, "Specifically, I'm convinced that saying "embedded on" is better than no string, but I'm not sure if it's precise in all cases." which could get further consideration. I'll make a separate bug for that topic. |
||
►
Sign in to add a comment |
||
Comment 1 by dschuyler@chromium.org
, Jun 1 2017