New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728773 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

WebM subsample (partitioned encrypted frame) should allow partition size to be 0

Project Member Reported by kqyang@chromium.org, Jun 1 2017

Issue description

This could happen if a particular frame only contains uncompressed headers (after 16-byte block alignment).

Right now Chrome does not accept 0-size partition and media parsing error is returned.
 
Cc: vasanthap@chromium.org
Status: Fixed (was: Untriaged)
Fixed in https://chromium-review.googlesource.com/c/521904/.

Not sure why Gerrit didn't post the CL automatically in this bug.. Some known problem with Gerrit?
Sometimes there's a delay in the process.

Comment 4 by kqyang@chromium.org, Jun 12 2017

Labels: Merge-Request-60
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please apply appropriate OSs.  Thanks.

Comment 7 by kqyang@chromium.org, Jun 12 2017

Labels: OS-All
Labels: -Merge-Review-60 Merge-Rejected-60
We're late into M60 and cracking down on merges for this milestone, I'd prefer to wait until M61.  If you feel strongly this should get merged, feel free to add back the Merge-Request-60 label and we'll re-review.
Cc: bustamante@chromium.org dalecur...@chromium.org modma...@google.com wolenetz@chromium.org rkuroiwa@chromium.org kqyang@chromium.org ti...@chromium.org
 Issue 718651  has been merged into this issue.
Cc: joeyparrish@chromium.org
Components: Internals>Media>Source
 Bug 718651  (shaka) hit this. joeyparrish@ / xhwang@ : Does shaka hitting this bug increase the merits of merging this to M-60?
Labels: -Merge-Rejected-60 Merge-Request-60
Added back Merge-Request-60 for re-review.

Project Member

Comment 12 by sheriffbot@chromium.org, Jun 13 2017

Labels: -Merge-Request-60 Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Approving for merge into M60 (build 3112) based on comments in 718651 and that it meets the other criteria.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 22 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeeb4a90b625101576e87b57360e61ce6ac73685

commit eeeb4a90b625101576e87b57360e61ce6ac73685
Author: KongQun Yang <kqyang@chromium.org>
Date: Thu Jun 22 00:05:28 2017

Allow encrypted partition size to be zero

This could happen if a media sample has less than 16 bytes of
compressed data, which can be left in clear if the packager
wants to block align encrypted data. In this case, the content
packager can mark the sample as not encrypted or mark the sample
as encrypted but with num_partitions = 0, which contains only
clear data effectively.

TBR=kqyang@chromium.org

(cherry picked from commit 7b5d7cc2759780ff45bba356566ba9c76e70c957)

Bug:  728773 
Change-Id: If0a3d2622307d1cb83b88e8637a28d463a3116d4
Reviewed-on: https://chromium-review.googlesource.com/521904
Commit-Queue: Kongqun Yang <kqyang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476812}
Reviewed-on: https://chromium-review.googlesource.com/543922
Reviewed-by: Kongqun Yang <kqyang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#436}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/eeeb4a90b625101576e87b57360e61ce6ac73685/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/eeeb4a90b625101576e87b57360e61ce6ac73685/media/formats/webm/webm_cluster_parser_unittest.cc
[modify] https://crrev.com/eeeb4a90b625101576e87b57360e61ce6ac73685/media/formats/webm/webm_crypto_helpers.cc
[modify] https://crrev.com/eeeb4a90b625101576e87b57360e61ce6ac73685/media/formats/webm/webm_crypto_helpers_unittest.cc

Sign in to add a comment