Elide behavior gfx::FADE_TAIL breaks coloring of text subparts |
||||||
Issue descriptionChrome Version: 61.0.3118.0 OS: Android 7.1.2 What steps will reproduce the problem? (1) Use gfx::FADE_TAIL instead of gfx::TRUNCATE as the elide behavior (e.g. here https://cs.chromium.org/chromium/src/chrome/browser/android/vr_shell/textures/url_bar_texture.cc?rcl=04b63e7cbb8aa3f8f27b0b42f2eaa9e890fed8ac&l=270). (2) Apply different colors to subparts of the text (e.g. here https://cs.chromium.org/chromium/src/chrome/browser/android/vr_shell/textures/url_bar_texture.cc?rcl=d161eb579eb2a491e59d82a616dde87c29eb65f1&l=84) (3) Draw a text that needs to be elided. What is the expected result? Tail fades out and the subparts are still correctly colored. What happens instead? The tail fades out but the entire text has the color of the first subpart. If gfx::FADE_TAIL is used but the text does not need be elided the colors are correct.
,
Jun 7 2017
Could you please assign this to someone else if you are not the right owner?
,
Jun 7 2017
I'm not aware of anyone actively dedicated to this text rendering area, sorry. Marking available and CC'ing folks that have done one-off work here 'recently'. Feel free to ping Chrome UI leads, there's a very slim chance I'd help in July. Giving some Pri-1 rationale might help, this generally doesn't affect browser UI.
,
Jun 19 2017
,
Jun 20 2017
,
Jul 10 2017
This doesn't seem to be too tough, but I couldn't see a handy way of finding the geometry of the items colors_ breaklist.
,
Jul 19 2017
We're no longer eliding with fading, we're using ellipsis. Closing this as there is no need to fix/support. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tiborg@chromium.org
, Jun 6 2017