New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728743 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 728080



Sign in to add a comment

[NTP::Push] Add Content Suggestions GCM App Handler

Project Member Reported by mamir@chromium.org, Jun 1 2017

Issue description

Add Content Suggestions GCM App Handler for content suggestions pushed via GCM
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b98495ac596af91308b9771afb98f18f73514d

commit 84b98495ac596af91308b9771afb98f18f73514d
Author: mamir <mamir@chromium.org>
Date: Fri Jun 09 18:25:42 2017

[NTP::Push] Add Content Suggestions GCM App Handler

BUG= 728743 

Review-Url: https://codereview.chromium.org/2922543002
Cr-Commit-Position: refs/heads/master@{#478340}

[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/DEPS
[add] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/breaking_news/content_suggestions_gcm_app_handler.cc
[add] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/breaking_news/content_suggestions_gcm_app_handler.h
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/breaking_news/subscription_manager.cc
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/breaking_news/subscription_manager.h
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/pref_names.cc
[modify] https://crrev.com/84b98495ac596af91308b9771afb98f18f73514d/components/ntp_snippets/pref_names.h

Comment 2 by mamir@chromium.org, Jun 9 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d20c161048a7c3db249389de7ebd0bd13dde66d4

commit d20c161048a7c3db249389de7ebd0bd13dde66d4
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Wed Jul 05 09:02:35 2017

[NTP::Push] Set the proper GCM sender id

Bug:  728743 
Change-Id: I0943b300d6dca2bbd24890d1d9119319a2dffc12
Reviewed-on: https://chromium-review.googlesource.com/559091
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484222}
[modify] https://crrev.com/d20c161048a7c3db249389de7ebd0bd13dde66d4/components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc41f2bad55034793426e5af70ef70485a7644b

commit 1dc41f2bad55034793426e5af70ef70485a7644b
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Wed Jul 05 18:02:27 2017

[NTP::Push] Renaming breaking_news_listener to _raw_data_provider

Bug:  728743 
Change-Id: Iff1f9c5c59e0ecc5d3cd1d544c93ebcd05501da5
Reviewed-on: https://chromium-review.googlesource.com/559541
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484307}
[modify] https://crrev.com/1dc41f2bad55034793426e5af70ef70485a7644b/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.cc
[modify] https://crrev.com/1dc41f2bad55034793426e5af70ef70485a7644b/components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h

Sign in to add a comment