New issue
Advanced search Search tips

Issue 728742 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 728064
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Racy reloads with patch set uploads are confusing

Project Member Reported by scottmg@chromium.org, Jun 1 2017

Issue description

I like the "Rebase" button, but reload of new patchsets flow is very confusing.

I've done the a bunch of times but for example here. https://chromium-review.googlesource.com/c/520607 starting at https://chromium-review.googlesource.com/c/520607#message-1022979d192030816c3fcff8bbbc678358ea0d48 .

I started a CQ, and then 10 minutes later realized it wanted to insist on rebasing on master first (leaving aside whether that's useful behaviour or not...)

So I clicked the shiny Rebase button to rebase it on master. Then when the UI "came back", I clicked "Submit to CQ" and closed the tab.

Half and hour later I checked to see if it had landed, but no, it had uselessly applied the CQ+2 to the non-rebased patchset, so it did nothing.

If I've done those two actions in sequence, the CQ+2 should be applied to the post-rebase patch set. Making the UI flows less racy/confusing would be much appreciated.
 
Mergedinto: 728064
Status: Duplicate (was: Unconfirmed)
Woah, that definitely shouldn't have happened. Yeah, after clicking the "rebase" button and letting the page reload, the CQ+2 button should definitely apply to the latest patchset.

But we're fixing it here, so it should all be better soon: cl/157655420

Sign in to add a comment