New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728741 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make CSD ReportType enum consistent

Project Member Reported by jialiul@chromium.org, Jun 1 2017 
in components/safe_browsing/csd.proto

message ClientSafeBrowsingReportRequest {...

enum ReportType has some inconsistent value names. Some has URL_as prefix, and some has _URL as suffix.

We need to make it consistent and update its counterpart in google3 as well.

Comment 1 by vakh@chromium.org, Jun 2 2017

Labels: -SafeBrowsing_Triaged SafeBrowsing-Triaged

Comment 2 by nikhil.s...@samsung.com, Jun 6 2017 

Will try to check this issue.

Comment 3 by nikhil.s...@samsung.com, Jun 6 2017 

Submitted https://codereview.chromium.org/2925693003/ for review .
Thanks !!!

Comment 4 by vakh@chromium.org, Jun 9 2017

Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a

commit 70433a95ffaa5bf34f0dbed3466ea36573ba6d4a
Author: nikhil.sahni <nikhil.sahni@samsung.com>
Date: Tue Jun 13 14:02:45 2017

Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG= 728741 

Review-Url: https://codereview.chromium.org/2925693003
Cr-Commit-Position: refs/heads/master@{#479002}

[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/safe_browsing/threat_details_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing/base_ping_manager.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing/base_ping_manager_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing/csd.proto
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing_db/v4_local_database_manager_unittest.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/safe_browsing_db/v4_protocol_manager_util.h
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/security_interstitials/content/unsafe_resource.cc
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/security_interstitials/content/unsafe_resource.h
[modify] https://crrev.com/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

Comment 6 by jialiul@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment