Compilation errors within neon-animation-runner-behavior-extracted.js |
|||
Issue descriptionAs part of addressing issue 721073, I added a compiled_resources2.gyp dependency to neon-animation-runner-behavior-extracted.js. I am getting the following errors within that file: (ERROR) Error in: viewer-pdf-toolbar.js ## /usr/local/google/home/dpapad/workspace/chromium1/src/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js:18: ERROR - Property configure never defined on Element ## result = neonAnimation.configure(config); ## ^^^^^^^^^ ## ## /usr/local/google/home/dpapad/workspace/chromium1/src/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js:21: ERROR - Property timeline never defined on HTMLDocument ## result = document.timeline.play(result); ## ^^^^^^^^ ## ## /usr/local/google/home/dpapad/workspace/chromium1/src/third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js:45: ERROR - Property playState never defined on ? ## if (activeEntries[i].animation.playState != 'finished') { ## ^^^^^^^^^ At first glance, error #1: Compiler does not know the type of |neonAnimation|, requires a change within neon-animation-runner-behavior. errors #2 and #3: Compiler does not have the proper animation related externs to understand those.
,
Jun 1 2017
so, there's a few more parts to this: 1) there are externs in web-animations-js[1] (possibly in newer versions?[2]) 2) chrome has hand-written externs that are a subset of web-animations-js[3] 3) there are other duplicate subsets of web animations API lying around[4] ^ and it's not clear any of these will exactly match the whole Web Animations API spec when it's more formally agreed-upon / finalized. [1] https://github.com/web-animations/web-animations-js/tree/dev/externs (note the /dev/) [2] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/bower.json?l=64 [3] https://cs.chromium.org/chromium/src/third_party/closure_compiler/externs/web_animations.js [4] https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/externs.js
,
Jun 4 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Jun 1 2017