LLD fails to link angle_util.dll after .def file parser change |
|||
Issue descriptionIt complains about many missing __imp_gl* symbols: [8311/53972] LINK(DLL) angle_util.dll angle_util.dll.lib FAILED: angle_util.dll angle_util.dll.lib C:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./angle_util.dll.lib /DLL /OUT:./angle_util.dll /PDB:./angle_util.dll.pdb @./angle_util.dll.rsp ..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: warning: obj/third_party/angle/angle_util/shader_utils.obj: undefined symbol: __imp__glCreateShader@4 ... There's a large blame window from May 16 to May 24. Last green: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD/builds/5579 First red: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD/builds/5581 Good rev: r303235 Bad rev: r303799 Presumably this is Rui's change to import garbage collection, which was in at the first bad revision, reverted, and then came back in r303814 for the next build, which was at r303826.
,
Jun 1 2017
Reverting just the import GC change doesn't fix the issue either. I'll keep bisecting.
,
Jun 2 2017
I reverted the .def file parser in r304561, but then I went ahead and fixed it up and relanded it in r304573. We still have a bug for fastcall symbols in .def files, which I filed upstream as https://bugs.llvm.org//show_bug.cgi?id=33284.
,
Jun 23 2017
This went green eventually. The LLD bots are currently red, but for other reasons. |
|||
►
Sign in to add a comment |
|||
Comment 1 by r...@chromium.org
, Jun 1 2017