New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728725 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Allow back button to close tabs opened in new window.

Project Member Reported by mthiesse@chromium.org, Jun 1 2017

Issue description

Currently, if users follow a link that opens in a new tab, they can't return to their previous tab since we don't support tab management in VR.

We should just use the same back button behaviour CTA does.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2537fa873c33c1c2597b2f03d7a15d7c88d1da3e

commit 2537fa873c33c1c2597b2f03d7a15d7c88d1da3e
Author: Michael Thiessen <mthiesse@google.com>
Date: Fri Jun 02 19:46:07 2017

VR: Use system back button behaviour while in ChromeTabbedActivity.

This allows us to behave the same way CTA does when hitting the back button,
which includes closing tabs opened by links. However, we disable exiting
chrome when the back stack is exhausted.

This is important because we don't support manual tab management yet in VR,
so we don't want users to get stuck after a link opens in a new tab.

Bug:  728725 
Change-Id: I5c042bd9f902fdee3db56451de97fe944dcf293d
Reviewed-on: https://chromium-review.googlesource.com/519802
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476760}
[modify] https://crrev.com/2537fa873c33c1c2597b2f03d7a15d7c88d1da3e/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/2537fa873c33c1c2597b2f03d7a15d7c88d1da3e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/2537fa873c33c1c2597b2f03d7a15d7c88d1da3e/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/2537fa873c33c1c2597b2f03d7a15d7c88d1da3e/chrome/browser/android/vr_shell/ui_elements/url_bar.h

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 5 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c

commit 2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c
Author: Michael Thiessen <mthiesse@google.com>
Date: Mon Jun 05 14:35:51 2017

VR: Use system back button behaviour while in ChromeTabbedActivity.

This allows us to behave the same way CTA does when hitting the back button,
which includes closing tabs opened by links. However, we disable exiting
chrome when the back stack is exhausted.

This is important because we don't support manual tab management yet in VR,
so we don't want users to get stuck after a link opens in a new tab.

Bug:  728725 
Change-Id: I5c042bd9f902fdee3db56451de97fe944dcf293d
Reviewed-on: https://chromium-review.googlesource.com/519802
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476760}
Review-Url: https://codereview.chromium.org/2924593002 .
Cr-Commit-Position: refs/branch-heads/3112@{#151}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c/chrome/browser/android/vr_shell/ui_elements/url_bar.cc
[modify] https://crrev.com/2c81bbb26501c9f5dfa48abefd9c8b80dd161e5c/chrome/browser/android/vr_shell/ui_elements/url_bar.h

Status: Fixed (was: Started)
Verified in Chrome Canary 61.0.3123.0
Status: Verified (was: Fixed)
Labels: -M60 M-60
Cc: joshcarpenter@chromium.org mthiesse@chromium.org vollick@chromium.org meganlindsay@chromium.org
 Issue 723833  has been merged into this issue.

Sign in to add a comment