New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 728713 link

Starred by 1 user
Status: Archived
Owner:
hansberry@chromium.org
Closed: Jun 2017
Cc:
█ jlklein@chromium.org
█ lesliewatkins@chromium.org
khorimoto@chromium.org
█ sacomoto@chromium.org
jhawkins@chromium.org
█ tengs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 672263



Sign in to add a comment

RemoteDevice's are_beacon_seeds_loaded field is not always initialized

Project Member Reported by hansberry@chromium.org, Jun 1 2017 
The new RemoteDevice are_beacon_seeds_loaded field introduced in crrev.com/2859053003 is only initialized in the second constructor of RemoteDevice. Because generally only the second constructor is used, the issues this causes have mostly gone unnoticed. However, in testing, for example with remote_device_test_util.cc, where the empty constructor is used, are_beacon_seeds_loaded being uninitialized causes RemoteDevice comparison bugs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d0b5dfa22bbc761575c3627e7627819ec8b4c8c

commit 7d0b5dfa22bbc761575c3627e7627819ec8b4c8c
Author: hansberry <hansberry@chromium.org>
Date: Thu Jun 01 19:04:22 2017

Always initialize the are_beacon_seeds_loaded field of RemoteDevice.

BUG= 728713 

Review-Url: https://codereview.chromium.org/2915133002
Cr-Commit-Position: refs/heads/master@{#476378}

[modify] https://crrev.com/7d0b5dfa22bbc761575c3627e7627819ec8b4c8c/components/cryptauth/remote_device.cc
[modify] https://crrev.com/7d0b5dfa22bbc761575c3627e7627819ec8b4c8c/components/cryptauth/remote_device.h

Comment 2 by hansberry@chromium.org, Jun 1 2017

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment