Issue metadata
Sign in to add a comment
|
1%-50% regression in media.tough_video_cases_tbmv2 at 475316:475394 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 1 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8977970925038206832
,
Jun 1 2017
=== Auto-CCing suspected CL author cbruni@chromium.org === Hi cbruni@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Camillo Bruni Commit : e822488d76755d9fdb9938adb01c90428f5b7131 Date : Mon May 29 13:27:17 2017 Subject: [runtime] Directly support double values in CloneShallowObjectLiteral Bisect Details Configuration: win_perf_bisect Benchmark : media.tough_video_cases_tbmv2 Metric : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:effective_size_min/video.html?src_crowd2160.mp4 Change : 50.00% | 1048576.0 -> 1572864.0 Revision Result N chromium@475361 1048576 +- 0.0 6 good chromium@475378 1048576 +- 0.0 6 good chromium@475386 1048576 +- 0.0 6 good chromium@475388 1048576 +- 0.0 6 good chromium@475388,v8@2ba1fcda5f 1048576 +- 0.0 6 good chromium@475388,v8@74681db644 1048576 +- 0.0 6 good chromium@475388,v8@e822488d76 1572864 +- 0.0 6 bad <-- chromium@475388,v8@8f7af5fb13 1572864 +- 0.0 6 bad chromium@475389 1572864 +- 0.0 6 bad chromium@475390 1572864 +- 0.0 6 bad chromium@475394 1572864 +- 0.0 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.crowd2160.mp4 media.tough_video_cases_tbmv2 Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8977970925038206832 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6710966407921664 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 2 2017
Issue 728700 has been merged into this issue.
,
Jun 2 2017
Issue 728699 has been merged into this issue.
,
Jun 2 2017
Issue 728709 has been merged into this issue.
,
Jun 2 2017
Issue 728702 has been merged into this issue.
,
Jun 2 2017
,
Jun 2 2017
Issue 728712 has been merged into this issue.
,
Jun 2 2017
Issue 728708 has been merged into this issue.
,
Jun 3 2017
Issue 728710 has been merged into this issue.
,
Jun 5 2017
,
Jun 16 2017
Issue 728532 has been merged into this issue.
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2 commit c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2 Author: Camillo Bruni <cbruni@chromium.org> Date: Fri Jun 16 12:51:10 2017 [runtime] Handle deprecated boilerplate maps correctly With the introduction of the fast-cloning double fields in the CSA stub for literals we forgot to check for deprecated maps. As a result every subsequent IC-miss would have to migrate the objects from such boilerplates. This CL makes sure we don't use the deprecated map when copying boilerplates, thus restoring the original behavior. Bug: v8:6211 chromium:728682 Change-Id: If9ea1e0c5c6fb4236cb7a82ea33306a600925ac3 Reviewed-on: https://chromium-review.googlesource.com/538677 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#45981} [modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/src/builtins/builtins-constructor-gen.cc [modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/src/runtime/runtime-literals.cc [modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/test/mjsunit/allocation-site-info.js
,
Jun 20 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by liberato@google.com
, Jun 1 2017