New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728682 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-50% regression in media.tough_video_cases_tbmv2 at 475316:475394

Project Member Reported by liberato@google.com, Jun 1 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=728682

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxq6StgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv2QgwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxozY9gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghvLq6wsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsqMtwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsfstQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxujEkggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghueT_wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpKU5gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpWGogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rrq2QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxuOqqgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqH66QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxo6kvwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoeuoAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-qWV4AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoeyvgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghseM7woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoekrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrPwtAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvv_tgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtbr8gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtLc-AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpqcuwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpX1qgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsrl4QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtiinQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuG4kQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqympgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-oO88gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vyorgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxti2vAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtLc-AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvCekQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghoepmwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrSp-AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsbCpggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghu6P6QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpq_kQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpq_4QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrWloQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghojs3gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghu-dhQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghu-d-QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuO5tQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrOsrQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxuWj5AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpSO9QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuXE8goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvb_7goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv3-6gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv6XpgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxuXXtQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpjM_wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrXPqQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqe4pAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsbYmwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqbzlggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrDcqQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrHTvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vyorgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghvuf7QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghu6P6QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgho6E4gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-o_-owkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgho6E4gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghozGowsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtSV9wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpja4QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtSVtwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghvafvQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgho6E4goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvb_rgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghveDiwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxujpuwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghufgqgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvb_rgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqHf7QkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqympgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-sOusQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrjPsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqfWrAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-u2wnAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghq_QowsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvaRuwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpOGqgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqH6qQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqWrggkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqedogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpmitgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsXKpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtbr8ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtKwhwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpKUpgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuePoQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrT44QkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoDZuQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghp_TqgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrjqtgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-rrqmQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsO09AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDght-x_wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtKwhwgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqiIsQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqP7vQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDght2V7wsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv2M4gsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsG9gwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqWmugkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqfWrAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvb_rgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrizoAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpXhswkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpqc2woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghueTvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvLVuQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtyHtwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqf7swsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuPXvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsOgpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvLw_ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoz7qAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-o_-wwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpPIogsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpqc2wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpO_rgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsGXvwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqWrgggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghoj6gAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpPIogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpO_rgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpiwrgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpXhswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrXq7gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpjaoQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrCt-woM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-q2SyQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghrvO5ggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxubWoQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrilvgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsDlpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv-NtgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-s2IqgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghvTK8AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpqcmwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghoj6gAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-vPtygkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtL1rQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghvGNrgsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxor2ogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtiirQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv_rrwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghp--ogkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxraepAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsO0tAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghu2rmQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-uejkgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-sOusQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghr22-QoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghq_QowkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-um-0AkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-x64-dual
win-high-dpi
Cc: cbruni@chromium.org
Owner: cbruni@chromium.org

=== Auto-CCing suspected CL author cbruni@chromium.org ===

Hi cbruni@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Camillo Bruni
  Commit : e822488d76755d9fdb9938adb01c90428f5b7131
  Date   : Mon May 29 13:27:17 2017
  Subject: [runtime] Directly support double values in CloneShallowObjectLiteral

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : media.tough_video_cases_tbmv2
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:code_space:effective_size_min/video.html?src_crowd2160.mp4
  Change       : 50.00% | 1048576.0 -> 1572864.0

Revision                           Result              N
chromium@475361                    1048576 +- 0.0      6      good
chromium@475378                    1048576 +- 0.0      6      good
chromium@475386                    1048576 +- 0.0      6      good
chromium@475388                    1048576 +- 0.0      6      good
chromium@475388,v8@2ba1fcda5f      1048576 +- 0.0      6      good
chromium@475388,v8@74681db644      1048576 +- 0.0      6      good
chromium@475388,v8@e822488d76      1572864 +- 0.0      6      bad       <--
chromium@475388,v8@8f7af5fb13      1572864 +- 0.0      6      bad
chromium@475389                    1572864 +- 0.0      6      bad
chromium@475390                    1572864 +- 0.0      6      bad
chromium@475394                    1572864 +- 0.0      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=video.html.src.crowd2160.mp4 media.tough_video_cases_tbmv2

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977970925038206832

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6710966407921664


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 728700  has been merged into this issue.
 Issue 728699  has been merged into this issue.
 Issue 728709  has been merged into this issue.
 Issue 728702  has been merged into this issue.
Cc: jasontiller@chromium.org
 Issue 728363  has been merged into this issue.
 Issue 728712  has been merged into this issue.
 Issue 728708  has been merged into this issue.
 Issue 728710  has been merged into this issue.
Cc: jarin@google.com
 Issue 729551  has been merged into this issue.
Issue 728532 has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2

commit c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2
Author: Camillo Bruni <cbruni@chromium.org>
Date: Fri Jun 16 12:51:10 2017

[runtime] Handle deprecated boilerplate maps correctly

With the introduction of the fast-cloning double fields in the CSA stub for
literals we forgot to check for deprecated maps. As a result every subsequent
IC-miss would have to migrate the objects from such boilerplates.

This CL makes sure we don't use the deprecated map when copying boilerplates,
thus restoring the original behavior.

Bug:  v8:6211   chromium:728682 
Change-Id: If9ea1e0c5c6fb4236cb7a82ea33306a600925ac3
Reviewed-on: https://chromium-review.googlesource.com/538677
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45981}
[modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/src/builtins/builtins-constructor-gen.cc
[modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/src/runtime/runtime-literals.cc
[modify] https://crrev.com/c2c4de293fdeaedc9e0fe5e02c31dd77b185d4d2/test/mjsunit/allocation-site-info.js

Status: Fixed (was: Untriaged)

Sign in to add a comment