New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728660 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Implement experiment to disable Cast overlay

Project Member Reported by mlamouri@chromium.org, Jun 1 2017

Issue description

In order to help figure out the impact of the Cast overlay, on Android, we would like to have an experiment that will turn it off so it can be A/B tested.

Related doc: https://docs.google.com/document/d/1bnkCUG3c0AO4NWY42Kcx72z6iN9ga_ZtYBNUGch-mBo/edit
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd

commit 9f34e33cccb12917a71c2c3b6ec1077db28fbbdd
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Jun 06 16:37:05 2017

Implement experiment to disable Cast overlay

Add an feature flag for 'MediaCastOverlayButton' to enable/disable
the cast overlay button. Defaults to ON for Android.

BUG= 728660 

Change-Id: I00dff0385b8397e9885987b5fe5dcd66022b5d76
Reviewed-on: https://chromium-review.googlesource.com/521562
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477309}
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/content/child/runtime_features.cc
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/media/base/media_switches.cc
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/media/base/media_switches.h
[add] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=MediaCastOverlayButton
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/9f34e33cccb12917a71c2c3b6ec1077db28fbbdd/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Status: Fixed (was: Started)

Sign in to add a comment