New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728659 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Task



Sign in to add a comment

Add browser test for macOS spellcheck

Project Member Reported by rlanday@chromium.org, Jun 1 2017

Issue description

In  crbug.com/727172 , a CL was landed that broke Mac spellchecking (it broke creating spellcheck markers with empty description strings, which is apparently all spellcheck markers on Mac), and no test case caught this. We should try to write a test that checks if Mac spellchecking works, probably a browser test (apparently layout tests do not run code in components/spellcheck/).
 

Comment 1 by noel@chromium.org, Jun 2 2017

Capture the relevant code-review chit-chat:
> > > rlanday@
> > > seems a little bizarre though that you can
> > > apparently entirely break Mac spellchecking and there's no test for that.

> > noel@
> > Concur, bizarre.  A layout test would overcome any limitations of having unit
> > tests only (which, as we can in the current case, can fail to warn us).

> > xiaochengh@
> Unfortunately layout tests don't run code in components/spellcheck/, so it still
> doesn't cover it...
> I'm thinking a full browser test, since spellchecking goes through all layers of
> Chrome.

I'm wondering: how would a browser test verify that the siggley-red-lines under misspelt are drawn?
I discovered today that this same problem where you can totally break spellcheck without triggering any test cases also exists on Android. Seems that a layout test would be the best way to check that the red underlines are drawn (is there a way to force the spellcheck code to run?).
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 18 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)

Sign in to add a comment