VR: Headset insertion goes to DD home after switching tabs from webVR to non-webVR |
|||||||
Issue description1. Open a webVR tab and a non-webVR tab. 2. Switch from the non-webVR tab to the webVR tab, then back to the non-webVR tab. 3. Insert your phone in to the DD headset. Actual: DD home is shown. Expected: The tab enters VR.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7feb50fb4b20c5c6065a17b9210d29cff3ef5477 commit 7feb50fb4b20c5c6065a17b9210d29cff3ef5477 Author: Michael Thiessen <mthiesse@google.com> Date: Thu Jun 01 22:33:45 2017 VR: Don't unregister Daydream intent when leaving webVR page if browsing is supported. If we support browsing in VR, when we leave a page that support presentation on headset insertion, don't unregister the Daydream intent. Bug: 728638 Change-Id: Ie9087e2a2a35a6e5d5839b6f1ef0672ba3b781aa Reviewed-on: https://chromium-review.googlesource.com/521942 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#476459} [modify] https://crrev.com/7feb50fb4b20c5c6065a17b9210d29cff3ef5477/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jun 2 2017
,
Jun 2 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/565e96bdfad900f9adb3232e147288b67b378f0c commit 565e96bdfad900f9adb3232e147288b67b378f0c Author: Michael Thiessen <mthiesse@google.com> Date: Mon Jun 05 14:19:29 2017 VR: Don't unregister Daydream intent when leaving webVR page if browsing is supported. If we support browsing in VR, when we leave a page that support presentation on headset insertion, don't unregister the Daydream intent. Bug: 728638 Change-Id: Ie9087e2a2a35a6e5d5839b6f1ef0672ba3b781aa Reviewed-on: https://chromium-review.googlesource.com/521942 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476459} Review-Url: https://codereview.chromium.org/2917353004 . Cr-Commit-Position: refs/branch-heads/3112@{#147} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/565e96bdfad900f9adb3232e147288b67b378f0c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jun 5 2017
,
Jun 8 2017
Verified in Chrome Canary 61.0.3123.0
,
Jun 8 2017
,
Jul 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mthiesse@chromium.org
, Jun 1 2017Status: Started (was: Available)