I have a test that contains:
@RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.Add({BottomSheetTestRule.ENABLE_CHROME_HOME,
ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
ChromeTabbedActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
@Restriction(RESTRICTION_TYPE_PHONE) // ChromeHome is only enabled on phones
public class ChromeHomeAppMenuTest {
...
If I run git cl presubmit --force -u I get:
** Presubmit Warnings **
The src directory requires source formatting. Please run git cl format .
If I then run git cl format my code changes to:
/**
* Tests for the app menu when Chrome Home is enabled.
*/
@RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.
Add({BottomSheetTestRule.ENABLE_CHROME_HOME, ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
ChromeTabbedActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
@Restriction(RESTRICTION_TYPE_PHONE) // ChromeHome is only enabled on phones
public class ChromeHomeAppMenuTest {
...
Now, trying git cl presubmit again I get:
** Presubmit ERRORS **
chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java:35:18: '.' should be on a new line.
chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java:36: 'Add' have incorrect indentation level 0, expected level should be 8.
I have so far been unable to find any layout of this code that gives neither a presubmit error nor a presubmit warning.
jbudorick@ - not sure if you are the right owner for this, please re-assign if not.
Comment 1 by jbudorick@chromium.org
, Jun 15 2017Owner: ----
Status: Available (was: Assigned)