New issue
Advanced search Search tips

Issue 728623 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 768576



Sign in to add a comment

Conflict between git cl format and presubmit on Java annotation

Project Member Reported by aber...@chromium.org, Jun 1 2017

Issue description

I have a test that contains:

@RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.Add({BottomSheetTestRule.ENABLE_CHROME_HOME,
        ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
        ChromeTabbedActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
@Restriction(RESTRICTION_TYPE_PHONE) // ChromeHome is only enabled on phones
public class ChromeHomeAppMenuTest {
...


If I run git cl presubmit --force -u I get:

** Presubmit Warnings **
The src directory requires source formatting. Please run git cl format .

If I then run git cl format my code changes to:

/**
 * Tests for the app menu when Chrome Home is enabled.
 */
@RunWith(ChromeJUnit4ClassRunner.class)
@CommandLineFlags.
Add({BottomSheetTestRule.ENABLE_CHROME_HOME, ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
        ChromeTabbedActivityTestRule.DISABLE_NETWORK_PREDICTION_FLAG})
@Restriction(RESTRICTION_TYPE_PHONE) // ChromeHome is only enabled on phones
public class ChromeHomeAppMenuTest {
...


Now, trying git cl presubmit again I get:


** Presubmit ERRORS **
  chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java:35:18: '.' should be on a new line.
  chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/ChromeHomeAppMenuTest.java:36: 'Add' have incorrect indentation level 0, expected level should be 8.


I have so far been unable to find any layout of this code that gives neither a presubmit error nor a presubmit warning.

jbudorick@ - not sure if you are the right owner for this, please re-assign if not.
 
Cc: jbudorick@chromium.org
Owner: ----
Status: Available (was: Assigned)
I'm not, and I'm not sure who is :(

I'll ask around, though.
Components: Build Infra>SDK

Comment 3 by thakis@chromium.org, Sep 25 2017

Blockedon: 768576
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 26

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Please reopen if this is still an issue.

Sign in to add a comment