New issue
Advanced search Search tips

Issue 728607 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Upstream PiP Code

Project Member Reported by peconn@chromium.org, Jun 1 2017

Issue description

Move Picture in Picture code upstream - this should allow us to get rid of stubs and simplify compilation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/4546335d8b03fa6140368769f3e8102e7af495e7

commit 4546335d8b03fa6140368769f3e8102e7af495e7
Author: Peter E Conn <peconn@google.com>
Date: Fri Jun 02 13:38:50 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2173cfdd4b05f7ab2687e1a043c294c59b6138

commit 9e2173cfdd4b05f7ab2687e1a043c294c59b6138
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Jun 02 15:34:48 2017

📺 Move PiP code upstream.

This moves Picture in Picture code into the public Chromium repository.
In addition it:
- Renames VideoPersisterInternal to PictureInPictureController.
- Makes PictureInPictureController not a singleton.
- Removes shouldDelayFullscreenModeChange.
- Uses the deprecated enterPictureInPicture zero argument method to
  avoid having to include the class of the argument, which may not yet
  be present on all builders. (Using the deprecated method is easier
  than loading the class via reflection.)

Downstream counterpart:
  https://chrome-internal-review.googlesource.com/c/386349/
 
BUG= 728607 

Change-Id: I6f62647a54658acdc218af7bbf66058afe3d7992
Reviewed-on: https://chromium-review.googlesource.com/521127
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476666}
[modify] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[modify] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[add] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPictureController.java
[delete] https://crrev.com/6666e3d76a0f228dc3631411235c6e20adfdc37a/chrome/android/java/src/org/chromium/chrome/browser/media/VideoPersister.java
[modify] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/9e2173cfdd4b05f7ab2687e1a043c294c59b6138/chrome/android/java_sources.gni

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c459ada45bbe815ce76a9dc9be9d803251131d5

commit 3c459ada45bbe815ce76a9dc9be9d803251131d5
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Jul 06 11:06:05 2017

PIP: implement AppHooks' shouldDetectVideoFullscreen in Chromium.

This will allow us to remove the implementation downstream without
breaking the official builds. This change will also allow PIP to
actually work with a Chromium build.

Bug:  728607 
Change-Id: I7b1a8c173309ce35321cd75281ba5a108eaac10b
Reviewed-on: https://chromium-review.googlesource.com/558973
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484541}
[modify] https://crrev.com/3c459ada45bbe815ce76a9dc9be9d803251131d5/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/830588ff2d2d79fc74841423dc78fc5a9334a4e6

commit 830588ff2d2d79fc74841423dc78fc5a9334a4e6
Author: Mounir Lamouri <mlamouri@google.com>
Date: Thu Jul 06 17:13:57 2017

Sign in to add a comment