New issue
Advanced search Search tips

Issue 728589 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Shorten time values in Swarming UI /tasklist

Project Member Reported by mar...@chromium.org, Jun 1 2017

Issue description

Datetime are printed via toLocalTime(). On fr_CA, this looks like:
"01/06/2017 à 08:49:53 (EDT)"

Two requests:
- Time zone should be printed in the column title, so it is not repeated in each value field. This would save 6 characters and reduce the noise significantly: "01/06/2017 à 08:49:53"
- When the day matches the current day, skip the date althogether, reducing to "08:49:53"

I don't see it that much necessary for /task as the number of timestamps printed is only an handful, and precision is more important there.
 
Labels: Hotlist-GoodFirstBug
Components: -Infra>Platform>Swarming Infra>Platform>Swarming>WebUI

Comment 3 by estaab@chromium.org, Jun 20 2017

Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/9ee2990d8c21bc8b40cd868bec10ab27d76adce9

commit 9ee2990d8c21bc8b40cd868bec10ab27d76adce9
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Nov 10 15:59:31 2017

swarming: Improve coherency of timestamps in the Web UI

- Use '‑' 'NON-BREAKING HYPHEN' (U+2011) instead of n/a or none, as this reduces
  the visual clutter. The goal is to make it clear there's no data, yet not to
  draw the eyes on these items.
- Enable removing the 'name' column; it's not necessary when just looking at raw
  pending times and it tends to be a very long column.
- Do not print the day when a timestamp is from today.
- Add $ on the cost_usd column, otherwise it's unclear why.
- Add a '*' as suffix for pending_time, duration and costs_usd if the task is
  still pending/running.

R=kjlubick@chromium.org
Bug: 728589
Change-Id: Ia0521dded9ce8c60e0cc651935f303c14036de15
Reviewed-on: https://chromium-review.googlesource.com/763927
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/build/js/js.js
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/res/imp/common/common-behavior.html
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/res/imp/tasklist/task-list.html
[modify] https://crrev.com/9ee2990d8c21bc8b40cd868bec10ab27d76adce9/appengine/swarming/ui/res/js/common.js

Comment 5 by mar...@chromium.org, Nov 10 2017

I'll keep open as I'd like to move the timezone into the header too.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Should be done in the new UI.

Sign in to add a comment