New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728588 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Be able to launch the qr code scanner from within the Keyboard Accessory View.

Project Member Reported by jif@chromium.org, Jun 1 2017

Issue description

There should be a camera icon next to the voice search button.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a1d81d83b120a07933838d25989a2ef80b471f

commit 45a1d81d83b120a07933838d25989a2ef80b471f
Author: jif <jif@chromium.org>
Date: Fri Jun 02 15:03:10 2017

[iOS] Factor out the KeyboardAccessoryView.

This CL moves the code describing the KeyboardAccessoryView to a separate
class.

Notable changes:
*Communication with the WebToolbarController now occurs via the
KeyboardAccessoryViewDelegate.
*The preloading of Voice Search now occurs on all touch downs, as opposed to
only the first touch down. This shouldn't be a problem, because preloading could
already happen multiple time (by pressing the voice icon in the toolbar, and then
pressing the voice icon in the keyboard accessory view).

BUG= 728588 

Review-Url: https://codereview.chromium.org/2914193002
Cr-Commit-Position: refs/heads/master@{#476651}

[modify] https://crrev.com/45a1d81d83b120a07933838d25989a2ef80b471f/ios/chrome/browser/ui/toolbar/BUILD.gn
[add] https://crrev.com/45a1d81d83b120a07933838d25989a2ef80b471f/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.h
[add] https://crrev.com/45a1d81d83b120a07933838d25989a2ef80b471f/ios/chrome/browser/ui/toolbar/keyboard_accessory_view.mm
[modify] https://crrev.com/45a1d81d83b120a07933838d25989a2ef80b471f/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Comment 2 by jif@chromium.org, Jun 20 2017

Mergedinto: 642702
Status: Duplicate (was: Started)

Sign in to add a comment