New issue
Advanced search Search tips

Issue 728566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add suppressions for upcoming Skia roll

Project Member Reported by robertphillips@chromium.org, Jun 1 2017

Issue description

The Skia CL:

https://skia-review.googlesource.com/c/18239/ (Disable deferred proxies for M60 branch)

causes imperceptible diffs in the following layout tests

  virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png.html [ Failure ]
  virtual/gpu-rasterization/images/color-profile-background-image-cross-fade.html [ Failure ]
  virtual/gpu-rasterization/images/color-profile-mask-image-svg.html [ Failure ]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84ca44746a87520343acd76a40d51b948d9e56a8

commit 84ca44746a87520343acd76a40d51b948d9e56a8
Author: robertphillips <robertphillips@google.com>
Date: Thu Jun 01 13:13:13 2017

Add suppressions for upcoming Skia DEPS roll

TBR=fmalita@chromium.org
BUG= 728566 

Review-Url: https://codereview.chromium.org/2916873002
Cr-Commit-Position: refs/heads/master@{#476264}

[modify] https://crrev.com/84ca44746a87520343acd76a40d51b948d9e56a8/third_party/WebKit/LayoutTests/TestExpectations

Cc: fmalita@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e58281b23c8e05b30d64503d6baa75809e4b46

commit b7e58281b23c8e05b30d64503d6baa75809e4b46
Author: reed <reed@google.com>
Date: Thu Jun 01 20:09:43 2017

suppress 2 layout images for skia spriteblitter change

Skia change: https://skia-review.googlesource.com/c/18238/

BUG= 728566 
NOTRY=True

Review-Url: https://codereview.chromium.org/2916143002
Cr-Commit-Position: refs/heads/master@{#476402}

[modify] https://crrev.com/b7e58281b23c8e05b30d64503d6baa75809e4b46/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcd54689343f21757d91f8411868509e618e93fc

commit dcd54689343f21757d91f8411868509e618e93fc
Author: robertphillips <robertphillips@google.com>
Date: Tue Jun 13 14:03:39 2017

Autorebaseline layout tests suppressed for Skia DEPS roll

The CL that caused the layout test diffs rolled into Chrome in https://chromium-review.googlesource.com/c/520713 at 476287.

BUG= 728566 

Review-Url: https://codereview.chromium.org/2916903003
Cr-Commit-Position: refs/heads/master@{#479003}

[modify] https://crrev.com/dcd54689343f21757d91f8411868509e618e93fc/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd

commit 2ab9c3e0419fd5eed46456cf2b6f772525ba45bd
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Jun 13 15:50:26 2017

Auto-rebaseline for r479003

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/717683

https://chromium.googlesource.com/chromium/src/+/dcd54689343f2

BUG= 728566 
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2938623002 .
Cr-Commit-Position: refs/heads/master@{#479033}

[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-background-image-cross-fade-png-expected.png
[modify] https://crrev.com/2ab9c3e0419fd5eed46456cf2b6f772525ba45bd/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/color-profile-mask-image-svg-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment