New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728558 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Not on Chrome anymore
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 1
Type: Bug

Blocked on:
issue 739331



Sign in to add a comment

CHECK failure: !keyword.empty() in template_url_data.cc

Project Member Reported by ClusterFuzz, Jun 1 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6172675193176064

Fuzzer: libFuzzer_template_url_parser_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !keyword.empty() in template_url_data.cc
  base::debug::DebugBreak
  TemplateURLData::SetKeyword
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=469306:469316

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6172675193176064


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs M-61
Owner: hashimoto@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL did not provide any possible suspects.
Using Code Search for the file, "template_url_data.cc" assigning to the concern owner using Git Blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/fa817b17e3198710708050cd11533a3436533b8e

@hashimoto -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Owner: bauerb@chromium.org
Reassigning to bauerb@ who recently touched template_url_data.cc in https://chromium-review.googlesource.com/c/539417
Components: UI>Browser>Omnibox>TabToSearch
Labels: -OS-Linux OS-All
Status: Started (was: Assigned)
The TemplateURLParser doesn't like empty <Alias> elements, it seems.
Project Member

Comment 4 by ClusterFuzz, Jul 5 2017

Labels: OS-Linux
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5230e468c0236f021df3a4939c99f9ab86433af

commit b5230e468c0236f021df3a4939c99f9ab86433af
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Thu Jul 06 16:30:20 2017

Don't set empty keyword when parsing search engines from OpenSearch description files.

Bug:  728558 
Change-Id: I721b053dac06bdec283c7bf00780019cd26ec8d0
Reviewed-on: https://chromium-review.googlesource.com/561140
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484625}
[modify] https://crrev.com/b5230e468c0236f021df3a4939c99f9ab86433af/components/search_engines/template_url_parser.cc

Project Member

Comment 6 by ClusterFuzz, Jul 7 2017

ClusterFuzz has detected this issue as fixed in range 484615:484759.

Detailed report: https://clusterfuzz.com/testcase?key=6172675193176064

Fuzzer: libFuzzer_template_url_parser_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !keyword.empty() in template_url_data.cc
  base::debug::DebugBreak
  TemplateURLData::SetKeyword
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=469306:469316
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=484615:484759

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6172675193176064


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6172675193176064 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 8 by bauerb@chromium.org, Jul 11 2017

Blockedon: 739331
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 18 2017

Sign in to add a comment