Issue 728524 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ shanmug...@samsung.com Last visit > 30 days ago
Closed:	Jun 2017
Cc:	editing-dev@chromium.org
Components:	Blink>Editing>IME
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

We should rename PlainText::end() to End()

Project Member Reported by yosin@chromium.org, Jun 1 2017

Issue description

Due by grate renaming, the tool kept PlainTextRange::end().
Since |PlainTextRange::end()| isn't for range, we should rename it to |End()|.

There are 47 references as of June 1, 2017.


See also [1] for VisbileSelection.

[1]  Issue 727486  We should rename VisibleSlection::end() to End()

Comment 1 by shanmug...@samsung.com, Jun 2 2017

Owner: shanmug...@samsung.com
Status: Started (was: Available)

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596241679d74362580facc364ce3c5d658a2a7cc

commit 596241679d74362580facc364ce3c5d658a2a7cc
Author: shanmuga.m <shanmuga.m@samsung.com>
Date: Wed Jun 07 09:30:18 2017

Rename PlainText::end() to PlainText::End()

This patch renames |PlainText::end()| to |PlainText::End()| to
follow the blink coding style.

BUG= 728524 

Review-Url: https://codereview.chromium.org/2926043002
Cr-Commit-Position: refs/heads/master@{#477596}

[modify] https://crrev.com/596241679d74362580facc364ce3c5d658a2a7cc/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/596241679d74362580facc364ce3c5d658a2a7cc/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/596241679d74362580facc364ce3c5d658a2a7cc/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
[modify] https://crrev.com/596241679d74362580facc364ce3c5d658a2a7cc/third_party/WebKit/Source/core/editing/PlainTextRange.h
[modify] https://crrev.com/596241679d74362580facc364ce3c5d658a2a7cc/third_party/WebKit/Source/core/exported/WebRange.cpp

Comment 3 by shanmug...@samsung.com, Jun 7 2017

Status: Fixed (was: Started)

►

Issue 728524 link

Issue metadata

We should rename PlainText::end() to End()

Issue description

Comment 1 by shanmug...@samsung.com, Jun 2 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 7 2017

Comment 2 Deleted

Comment 3 by shanmug...@samsung.com, Jun 7 2017

Comment 3 Deleted

Sign in to add a comment