New issue
Advanced search Search tips

Issue 728522 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTests/external/wpt/css/css-flexbox-1/css-flexbox-height-animation-stretch.html should not be run

Project Member Reported by foolip@chromium.org, Jun 1 2017

Issue description

This test is being classified as a manual test in MANIFEST.json, which means that we shouldn't run it. It's being run anyway, which isn't useful.
 
Components: Blink>Layout>Flexbox
Labels: Test-Layout
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/004ab809c3cc92738590c1493e9a58cc3063fa42

commit 004ab809c3cc92738590c1493e9a58cc3063fa42
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Thu Jun 01 11:10:53 2017

Import wpt@61057da21635a12c4af72c5de9b516caf73804ae (manual)

Using wpt-import in Chromium b28a65242a2788223545bdf1dbe77989125e4bba.

Reason for manual import: want my fullscreen/ tests ASAP.

BUG= 571531 , 728522 , 728527 
TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: I106230f7927f4a23a61d93ec3543cb900ea7ba24
Reviewed-on: https://chromium-review.googlesource.com/520384
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476249}
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox-1/css-flexbox-height-animation-stretch.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-001.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-002.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-003.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-004.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-005.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-006.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-007.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-008.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-009.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-010.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-011.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-012.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-013.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-014.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-015.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-016.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-001.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-002.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-003.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-004.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-005.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-007.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-008.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-009.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-010.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-011.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-012.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-013.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-014.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-015.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-016.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-001.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-002.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-003.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-004.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-005.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-007.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-008.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-009.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-010.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-011.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-012.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-013.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-014.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-015.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-016.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/support/check-layout-th.js
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-tfoot-bottom-ref.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-tfoot-bottom.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top-ref.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/css/css-position-3/position-sticky-table-thead-top.html
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/eventsource/eventsource-cross-origin.htm
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/document-exit-fullscreen-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/document-exit-fullscreen-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-exit-iframe-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-exit-iframe-manual.html
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual.html
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-not-allowed-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/api/element-request-fullscreen-not-allowed.html
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/interfaces-expected.txt
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/move-to-iframe-manual-expected.txt
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/move-to-iframe-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-first-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-first-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-last-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-last-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-parent-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-parent-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-single-manual-expected.txt
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/fullscreen/model/remove-single-manual.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-subgraph-404.html
[add] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/resources/delayed-modulescript.py
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/interfaces/fullscreen.idl
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
[delete] https://crrev.com/7ccdfaf7c1639a6f1e12d206fea9a608b6c33f44/third_party/WebKit/LayoutTests/external/wpt/scroll-into-view/check-scroll-position.html
[modify] https://crrev.com/004ab809c3cc92738590c1493e9a58cc3063fa42/third_party/WebKit/LayoutTests/external/wpt/url/interfaces.any.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7416d968b8248ee395249db297f792a6924fa8e

commit b7416d968b8248ee395249db297f792a6924fa8e
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Jun 01 20:51:06 2017

Move css-flexbox-height-animation-stretch.html to NeverFixTests.

In general we've been putting all of the manual tests that we never
want to run into NeverFixTests. It looks like this particular test was
imported before the csswg-test merge, and it should have been disabled
at that time but wasn't.

Bug:  728522 
Change-Id: I467c1c3db7d7a0417d521d18356d6ff56efb87f5
Reviewed-on: https://chromium-review.googlesource.com/521444
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476427}
[modify] https://crrev.com/b7416d968b8248ee395249db297f792a6924fa8e/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/b7416d968b8248ee395249db297f792a6924fa8e/third_party/WebKit/LayoutTests/TestExpectations

Is there anything left to do on this bug?
Status: Fixed (was: Untriaged)
Nope, I don't think so - Thanks for the reminder.
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment