New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728500 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add expansion function on new style Chrome notification.

Project Member Reported by fukino@chromium.org, Jun 1 2017

Issue description

Maybe we should not add size animation, to be consistent with Arc notifications.

 
Summary: Add expansion function on new style Chrome notification. (was: Add expansion animatio on new style Chrome notification.)
Status: Started (was: Assigned)
Labels: M-61

Comment 4 by yoshi@chromium.org, Jun 1 2017

Cc: -yoshi@chromium.org
Cc: yoshiki@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63a16add8253bc6a138329c648ba82a5492f11f0

commit 63a16add8253bc6a138329c648ba82a5492f11f0
Author: fukino <fukino@chromium.org>
Date: Mon Jun 12 10:56:17 2017

Notification: Implement two-leveled notification.

The new-style notification should have two states: Collapsed(default) and Expanded.
To implement the feature, this CL does:
* Create NotificationHeaderView which is responsible to keeps app_icon, app_name, expand_button, settings_button, and close_button.
* When the expand_button is clicked, some view's visibility and message_view's line limit is modified to have "expanded" view.

For simplicity, I avoided dynamic creation/deletion of views on expanded state change. The expanded state only changes the existing view's property.
If it hit noticeable performance regression, I'll update the way to change the view.

BUG= 728500 , 726242 
TEST=manually tested expand/collapse function on following notifications using --enabled-new-style-notification
* A basic notification with one-line message (This doesn't have expand icon.)
* A basic notificatoin with two-line message
* A basic notification with two buttons
* A image notification

Review-Url: https://codereview.chromium.org/2925263003
Cr-Commit-Position: refs/heads/master@{#478587}

[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/BUILD.gn
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/vector_icons/notification_expand_less.icon
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/vector_icons/notification_expand_more.icon
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_header_view.cc
[add] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_header_view.h
[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/63a16add8253bc6a138329c648ba82a5492f11f0/ui/message_center/views/notification_view_md.h

Status: Fixed (was: Started)
Thanks fukino@!

Sign in to add a comment