Regression: Added site urls overlaps with 'Add a new page' paper button at chrome://settings/onStartup
Reported by
nutan.ga...@etouch.net,
Jun 1 2017
|
||||||||
Issue descriptionChrome Version : 61.0.3117.0 0924893aff1ceb991c789862db5ecff6802330c1-refs/heads/master@{#476123} OS: Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch Chrome, navigate to chrome://settings/onStartup 2. Click on 'Open a specific page or set of pages' radio button 3. Click on 'Add a new page' and add 6 page name and observe Actual: Added site urls overlaps with 'Add a new page' paper button Expected: Overlapping should not be observed This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info. Good Build: 61.0.3116.0 Bad Build: 61.0.3117.0 Note: Will update MAC and LINUX OS status once build is available.
,
Jun 1 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3116.0 (Revision:475721). Bad build:61.0.3117.0 (Revision:476123). You are probably looking for a change made after 476066 (known good), but no later than 476067 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/53b8275babae3275605339cc09038d1dfbcf3ec0..e959cddaeca101036a8edf445a5d57c629632afc From the CL above, assigning the issue to the concern owner @dschuyler: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2902363002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3117.0
,
Jun 1 2017
,
Jun 2 2017
This screen shot shows that the action menu buttons moved slightly left to bring them entirely into the iron-list. (In the future it may be better to enlarge the list to the right).
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f60d062aad6f02456fb50f4f5d00936d47d08030 commit f60d062aad6f02456fb50f4f5d00936d47d08030 Author: dschuyler <dschuyler@chromium.org> Date: Fri Jun 02 17:12:38 2017 [MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG= 728493 , 728490 , 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Commit-Position: refs/heads/master@{#476699} [modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 2 2017
Merge candidate
,
Jun 6 2017
Merge-Request-60
,
Jun 7 2017
,
Jun 7 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3235d6e5d9211b5569d3a606b428c5cf98359cf4 commit 3235d6e5d9211b5569d3a606b428c5cf98359cf4 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 07 21:05:51 2017 [MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG= 728493 , 728490 , 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Original-Commit-Position: refs/heads/master@{#476699} Review-Url: https://codereview.chromium.org/2926643004 . Cr-Commit-Position: refs/branch-heads/3112@{#236} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 8 2017
Tested the issue on Mac 10.12.4,Windows 7 & Ubuntu 14.04 using chrome version#60.0.3112.24 with the steps mentioned in comment #0.Observed that the added site URL's are not overlapping with 'Add a new page' paper button as per the intended behavior. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thank you..!!
,
Jun 9 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nutan.ga...@etouch.net
, Jun 1 2017968 KB
968 KB View Download
859 KB
859 KB View Download