We need to implement GAIA-keyed logging of Translation Event. Design doc: https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkojv4/edit#heading=h.y797o5xrgqfy
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23fe0e721faec0123be8c521e377ff22c7fefe88 commit 23fe0e721faec0123be8c521e377ff22c7fefe88 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 14 00:10:43 2017 Implementation of translation event logging. Integration steps described in: https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit#heading=h.qdctas2f6c6e BUG= 728491 Review-Url: https://codereview.chromium.org/2913593002 Cr-Commit-Position: refs/heads/master@{#479219} [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/chrome/browser/translate/chrome_translate_client.h [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/DEPS [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/browser/mock_translate_client.h [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/browser/translate_client.h [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/browser/translate_ui_delegate_unittest.cc [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/common/BUILD.gn [add] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/common/translation_logging_helper.cc [add] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/common/translation_logging_helper.h [add] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/components/translate/core/common/translation_logging_helper_unittest.cc [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/ios/web_view/internal/translate/web_view_translate_client.h [modify] https://crrev.com/23fe0e721faec0123be8c521e377ff22c7fefe88/ios/web_view/internal/translate/web_view_translate_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdce2652bc147496e6d53348d80f21c8d7e7dec6 commit cdce2652bc147496e6d53348d80f21c8d7e7dec6 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 14 01:41:17 2017 Set up switches for user language detection and translation events. These two switches control logging language detection and translation events behavior. However, we still rely on SyncUserEvents as a centralized gateway to logging. BUG= 722679 , 728491 Review-Url: https://codereview.chromium.org/2932603002 Cr-Commit-Position: refs/heads/master@{#479247} [modify] https://crrev.com/cdce2652bc147496e6d53348d80f21c8d7e7dec6/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/cdce2652bc147496e6d53348d80f21c8d7e7dec6/components/sync/driver/sync_driver_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/106a571ac7652839571550ae6738086a4e787c31 commit 106a571ac7652839571550ae6738086a4e787c31 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 21 01:03:48 2017 Add switches for language detection and translation logging. Apply switches as previosuly discussed so we easily turn off language detection logging or translation logging if something goes wrong. BUG= 728491 , 722679 Review-Url: https://codereview.chromium.org/2941953002 Cr-Commit-Position: refs/heads/master@{#481054} [modify] https://crrev.com/106a571ac7652839571550ae6738086a4e787c31/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/106a571ac7652839571550ae6738086a4e787c31/chrome/browser/translate/chrome_translate_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef37fe771b578f8abc44c9fb5a6e28500aee0353 commit ef37fe771b578f8abc44c9fb5a6e28500aee0353 Author: renjieliu <renjieliu@chromium.org> Date: Mon Jun 26 02:24:14 2017 Split translate_event.proto AUTOMATICALLY_TRANSLATED. Split AUTOMATICALLY_TRANSLATED into AUTO_TRANSLATION_BY_PREF and AUTO_TRANSLATION_BY_LINK to allow us more fine grained analysis. BUG= 728491 , 722679 Review-Url: https://codereview.chromium.org/2938133003 Cr-Commit-Position: refs/heads/master@{#482184} [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/metrics/proto/translate_event.proto [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/sync/protocol/proto_enum_conversions.cc [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/sync/protocol/user_event_specifics.proto [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/ef37fe771b578f8abc44c9fb5a6e28500aee0353/components/translate/core/common/translation_logging_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edd3a026b008f41b7981b5b9786905d5d1b31b41 commit edd3a026b008f41b7981b5b9786905d5d1b31b41 Author: renjieliu <renjieliu@chromium.org> Date: Wed Jun 28 03:39:07 2017 Implement translate event for ios client. BUG= 728491 Review-Url: https://codereview.chromium.org/2943343003 Cr-Commit-Position: refs/heads/master@{#482872} [modify] https://crrev.com/edd3a026b008f41b7981b5b9786905d5d1b31b41/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/edd3a026b008f41b7981b5b9786905d5d1b31b41/ios/chrome/browser/translate/chrome_ios_translate_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61ffe40bc6dbafd8baebd66fc6737e8abee06036 commit 61ffe40bc6dbafd8baebd66fc6737e8abee06036 Author: renjieliu <renjieliu@chromium.org> Date: Fri Jun 30 00:55:17 2017 Add a unit test for translation event logging. BUG= 728491 Review-Url: https://codereview.chromium.org/2954053002 Cr-Commit-Position: refs/heads/master@{#483565} [modify] https://crrev.com/61ffe40bc6dbafd8baebd66fc6737e8abee06036/chrome/browser/translate/chrome_translate_client.h [modify] https://crrev.com/61ffe40bc6dbafd8baebd66fc6737e8abee06036/chrome/browser/translate/chrome_translate_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23673a4ae297c6d3958bea60e21d4c37e285f97a commit 23673a4ae297c6d3958bea60e21d4c37e285f97a Author: Sky Malice <skym@chromium.org> Date: Mon Aug 07 22:07:25 2017 Enable translation UserEvents on bots. Adding both detection/interaction event features for translate use case to ensure we get good test coverage. While in there, removing SyncUserEvents feature as it is now FEATURE_ENABLED_BY_DEFAULT. Bug: 728491 Change-Id: I6c6330f12aa54be29687bcf2ffde73c8add26eb0 Reviewed-on: https://chromium-review.googlesource.com/594934 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#492429} [modify] https://crrev.com/23673a4ae297c6d3958bea60e21d4c37e285f97a/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, Jun 14 2017