Regression : Ripple effect of "RELAUNCH" button overlaps with toggle button.
Reported by
avsha...@etouch.net,
Jun 1 2017
|
||||||
Issue descriptionChrome Version : 61.0.3117.0 (Official Build) 0924893aff1ceb991c789862db5ecff6802330c1-refs/heads/master@{#476123} 32/64 bit OS : Windows(7,8,10) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/privacy. 2. Toggle 'Automatically send usage statics.. option and click & hold on "RELAUNCH". 3. Observe the ripple effect on "RELAUNCH" button Actual : Ripple effect overlaps with toggle button. Expected : Ripple effect should not overlap with toggle button. This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info. Good build : 61.0.3116.0 Bad build : 61.0.3117.0
,
Jun 1 2017
Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e..6467c368ef17eae06b31e4bc99672c2514965feb?pretty=fuller&n=10000 Suspecting : r 476067 from Narrow Bisect @dschuyler : Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Thank you!
,
Jun 1 2017
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f60d062aad6f02456fb50f4f5d00936d47d08030 commit f60d062aad6f02456fb50f4f5d00936d47d08030 Author: dschuyler <dschuyler@chromium.org> Date: Fri Jun 02 17:12:38 2017 [MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG= 728493 , 728490 , 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Commit-Position: refs/heads/master@{#476699} [modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/f60d062aad6f02456fb50f4f5d00936d47d08030/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 2 2017
A candidate for merging
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3235d6e5d9211b5569d3a606b428c5cf98359cf4 commit 3235d6e5d9211b5569d3a606b428c5cf98359cf4 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 07 21:05:51 2017 [MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG= 728493 , 728490 , 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Original-Commit-Position: refs/heads/master@{#476699} Review-Url: https://codereview.chromium.org/2926643004 . Cr-Commit-Position: refs/branch-heads/3112@{#236} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html [modify] https://crrev.com/3235d6e5d9211b5569d3a606b428c5cf98359cf4/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 8 2017
Tested the fix on windows 7, Ubuntu 14.04 and Mac 10.12.5 using chrome version 60.0.3112.24. overlapping issue is not observed. Please find the attached screen shot for the same. adding TE-Verified labels. Thanks, |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by avsha...@etouch.net
, Jun 1 2017