New issue
Advanced search Search tips

Issue 728488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"AutofillInteractiveTest.DontAutofillForOutsideClick" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 1 2017

Issue description

"AutofillInteractiveTest.DontAutofillForOutsideClick" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPgsSBUZsYWtlIjNBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5Eb250QXV0b2ZpbGxGb3JPdXRzaWRlQ2xpY2sM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: se...@chromium.org
Owner: ma...@chromium.org
There are a ton of "AutofillInteractiveTest.* is flaky" bugs in the queue ( https://bugs.chromium.org/p/chromium/issues/list?q=AutofillInteractiveTest ).  Looking through the file, the majority of the tests seem to be disabled somewhere, especially CrOS and Windows.

This is a bad state of affairs.  We seem to be manually-disabling these tests one at a time.  It would likely be better to not have the tests at all than to have the current state.  Please consider investing high-priority time into this (e.g. by rewriting in a way that isn't an interactive UI test).

For now, assigning this to mathp since that's what was done on  bug 726659 ; but not disabling the test since (a) it's late and I'm tired and (b) I haven't taken enough time to see if more drastic solutions are warranted.  So, leaving in sheriff queue.
I'm marking DISABLED:
https://codereview.chromium.org/2919593006/
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac5e57d366931ea57244c45b01d55c01774fdfb

commit 3ac5e57d366931ea57244c45b01d55c01774fdfb
Author: yoichio <yoichio@chromium.org>
Date: Thu Jun 01 07:08:57 2017

Disable flaky AutofillInteractiveTest tests on Win

BUG= 728488 
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2919593006
Cr-Commit-Position: refs/heads/master@{#476218}

[modify] https://crrev.com/3ac5e57d366931ea57244c45b01d55c01774fdfb/chrome/browser/autofill/autofill_interactive_uitest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522146e8024f81aff5a7c076f5a819aec719ed99

commit 522146e8024f81aff5a7c076f5a819aec719ed99
Author: Greg Thompson <grt@chromium.org>
Date: Thu Oct 05 00:02:06 2017

Deflake ui_controls::SendMouseMove on Windows.

On Windows, SendMouseMove must transform a point in screen coordinates
into the range (0..2^16-1) for consumption by SendInput. Windows then
converts this back to screen coordinates. This change rounds up rather
than down in the initial conversion so that Windows lands on the correct
point when it seemly truncates.

Previously, we'd see off-by-one errors from time to time. While this may
seem insignificant at first blush, it's problematic when SendMouseMove
is called to move the mouse to a point where it already resides. No
events are generated by SendInput in this case, so the hook proc will
never be called. This shouldn't be a problem since SendMouseMove detects
this case and short-circuits the request. With the ob1, however,
SendMouseMove thinks it needs to move the mouse by one point, yet the
bad math results in a call to SendInput to move the mouse to its current
position. This makes tests timeout and all of us sad.

BUG= 390564 , 639940 , 710436 , 726659 , 728488 , 764415 
R=mathp@chromium.org, sky@chromium.org

Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03
Reviewed-on: https://chromium-review.googlesource.com/686898
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506574}
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/ui/send_mouse_move_uitest_win.cc
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/test/BUILD.gn
[modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/ui/base/test/ui_controls_internal_win.cc

Comment 6 by ma...@chromium.org, Dec 6 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment